test: add coverage for socket write after close #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
May 23, 2017
| const client = net.connect({port}, common.mustCall(() => { | ||
| client.on('error', common.mustCall((err) => { | ||
| server.close(); | ||
| assert.strictEqual(err.message, 'write EBADF'); |
There was a problem hiding this comment.
Nit: can we add an assertion for the error class?
assert.strictEqual(err.constructor, Error);
lpinca
approved these changes
May 23, 2017
cjihrig
force-pushed
the
connect
branch
2 times, most recently
from
29b2993 to
7169523
Compare
jasnell
approved these changes
May 25, 2017
refack
approved these changes
May 26, 2017
This commit adds test coverage for the scenario where a socket's handle has been closed prior to writing. PR-URL: nodejs#13171 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
This commit adds test coverage for the scenario where a socket's handle has been closed prior to writing. PR-URL: #13171 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
This commit adds test coverage for the scenario where a socket's handle has been closed prior to writing. PR-URL: #13171 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test coverage for the scenario where a socket's
handle has been closed prior to writing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test