Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: don't use useless constructors in stream.md #13145

Closed
wants to merge 1 commit into from
Closed

doc: don't use useless constructors in stream.md #13145

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, stream

Refs: http://eslint.org/docs/rules/no-useless-constructor

ES2015 provides a default class constructor if one is not specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class...

The constructors in these fragments could be completely removed to eliminate useless constructor promotion, but this would make the examples a bit bare, so I've decided to just add ellipses to hint at an extension of code.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels May 21, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels May 21, 2017
refack
refack approved these changes May 21, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea

mcollina
mcollina approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt
Copy link
Contributor Author

Landed in 6af72d4

@vsemozhetbyt vsemozhetbyt deleted the stream-no-useless-constructor branch May 24, 2017 00:56
vsemozhetbyt added a commit that referenced this pull request May 24, 2017
@vsemozhetbyt
doc: don't use useless constructors in stream.md
6af72d4 
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request May 24, 2017
@vsemozhetbyt @jasnell
doc: don't use useless constructors in stream.md
af8e4de 
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request May 28, 2017
@vsemozhetbyt @jasnell
doc: don't use useless constructors in stream.md
db90b50 
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@vsemozhetbyt @MylesBorins
doc: don't use useless constructors in stream.md
fb07fbc 
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@ryan-ally ryan-ally mentioned this pull request Jun 20, 2023
Open
@aliscco aliscco mentioned this pull request Jun 20, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 21, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 21, 2023
Open
@aliscco aliscco mentioned this pull request Jun 21, 2023
Open
@adamlaska adamlaska mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
@baby636 baby636 mentioned this pull request Jun 22, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
This was referenced Jul 6, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vsemozhetbyt @mcollina @refack @danbev @jasnell @cjihrig @MylesBorins @nodejs-github-bot