Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix title/function name mismatch #13123

Closed
wants to merge 1 commit into from
Closed

doc: fix title/function name mismatch #13123

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc, n-api

@mhdawson
doc: fix title/function name mismatch
1ad77df 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 19, 2017
@mhdawson
Copy link
Member Author

CI run: https://ci.nodejs.org/job/node-test-pull-request/8249/

@addaleax
Copy link
Member

Landed in f3ef971

@addaleax addaleax closed this May 23, 2017
addaleax pushed a commit that referenced this pull request May 23, 2017
@mhdawson @addaleax
doc: fix title/function name mismatch
f3ef971 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request May 24, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
a9b78b2 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request May 28, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
336d33b 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@mhdawson mhdawson deleted the napi-doc-fix2 branch June 28, 2017 19:23
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@mhdawson
doc: fix title/function name mismatch
2e48f58 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: nodejs#13123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@mhdawson @MylesBorins
doc: fix title/function name mismatch
2e29052 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
Backport-PR-URL: #19447
PR-URL: #13123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @addaleax @refack @jasnell @lpinca @cjihrig @gibfahn @nodejs-github-bot