Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix coverity warnings #13116

Merged
merged 1 commit into from
May 22, 2017
Merged

src: fix coverity warnings #13116

merged 1 commit into from
May 22, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 19, 2017

This commit checks the return value of two calls to uv_async_init().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels May 19, 2017
@cjihrig cjihrig mentioned this pull request May 19, 2017
Closed
3 tasks
@sam-github
Copy link
Contributor

The commit message could be more descriptive, maybe:

src: assert that uv_async_init succeeds

with the coverity message in the description.

@cjihrig
Copy link
Contributor Author

cjihrig commented May 19, 2017

Updated commit message. CI: https://ci.nodejs.org/job/node-test-pull-request/8178/

mhdawson
mhdawson approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
src: assert that uv_async_init() succeeds
06f62eb 
This commit fixes two coverity warnings for unchecked
return values.

Refs: nodejs#13050
PR-URL: nodejs#13116
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@cjihrig cjihrig merged commit 06f62eb into nodejs:master May 22, 2017
@cjihrig cjihrig deleted the coverity branch May 22, 2017 16:04
jasnell pushed a commit that referenced this pull request May 23, 2017
@cjihrig @jasnell
src: assert that uv_async_init() succeeds
95e0770 
This commit fixes two coverity warnings for unchecked
return values.

Refs: #13050
PR-URL: #13116
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
jasnell pushed a commit that referenced this pull request May 23, 2017
@cjihrig @jasnell
src: assert that uv_async_init() succeeds
1acd4d2 
This commit fixes two coverity warnings for unchecked
return values.

Refs: #13050
PR-URL: #13116
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 10, 2017
@cjihrig @MylesBorins
src: assert that uv_async_init() succeeds
17d5edc 
This commit fixes two coverity warnings for unchecked
return values.

Refs: #13050
PR-URL: #13116
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@cjihrig @MylesBorins
src: assert that uv_async_init() succeeds
f92e065 
This commit fixes two coverity warnings for unchecked
return values.

Refs: #13050
PR-URL: #13116
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@refack refack refack approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @sam-github @refack @addaleax @mhdawson @gibfahn @MylesBorins @nodejs-github-bot