build: clean up napi build in test-addons-clean #13034
Conversation
nodejs-github-bot
added
the
build
|
cc/ @nodejs/n-api @nodejs/build |
|
So you're exempt from dealing with |
|
@refack I agree there can be similar rules in |
IMHO there's no need... (If there was any logic IMHO is should have been changed here...) |
Interesting question, not sure if there's any difference between the two, except that if you've added some new files and not committed yet, The subtargets like |
Well then you enjoy your well-thought-of Makefile targets 😞 |
|
@refack Hmm..I didn't realize that |
|
I tend to agree that since there is a clean target for regular addons, bringing napi in line with that makes sense. If we decide that there is a better approach then a PR could address that for both the original addons and napi-addons. Any objections to landing based on that approach ? |
|
I was always +1, and as I said no need to add to |
|
Landed as 6342988 |
PR-URL: #13034 Ref: #13031 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rajaram Gaunker <[email protected]>
PR-URL: nodejs#13034 Ref: nodejs#13031 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rajaram Gaunker <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #13031
Affected core subsystem(s)
build