http: improve outgoing string write performance #13013

mscdex · 2017-05-13T14:32:04Z

These changes could be semver-major-y. One behavioral change introduced by this commit is that when writing a string that is the first chunk, it is no longer guaranteed to be sent immediately with the header. This is why the two tests had to be modified. It should be noted that this behavioral change actually brings it in line with what happens when writing a first Buffer chunk, so there would be consistency after this change. However I'm not sure if there is anyone that may be relying on the old string writing behavior...

One other possibly noticeable change is that chunk/data in end() is no longer validated if the outgoing message is already finished.

Anyway, here are some results:

                                                                                       improvement confidence      p.value
 http/simple.js res="normal" c=50 chunks=0 len=1024 type="buffer" benchmarker="wrk"       -1.46 %            3.762163e-01
 http/simple.js res="normal" c=50 chunks=0 len=1024 type="bytes" benchmarker="wrk"        -0.51 %            7.115831e-01
 http/simple.js res="normal" c=50 chunks=0 len=102400 type="buffer" benchmarker="wrk"     -1.34 %            4.010301e-01
 http/simple.js res="normal" c=50 chunks=0 len=102400 type="bytes" benchmarker="wrk"       0.59 %            1.274991e-01
 http/simple.js res="normal" c=50 chunks=0 len=4 type="buffer" benchmarker="wrk"          -0.40 %            8.526384e-01
 http/simple.js res="normal" c=50 chunks=0 len=4 type="bytes" benchmarker="wrk"            0.37 %            8.122313e-01
 http/simple.js res="normal" c=50 chunks=1 len=1024 type="buffer" benchmarker="wrk"       -0.94 %            3.148300e-01
 http/simple.js res="normal" c=50 chunks=1 len=1024 type="bytes" benchmarker="wrk"        -0.05 %            9.575339e-01
 http/simple.js res="normal" c=50 chunks=1 len=102400 type="buffer" benchmarker="wrk"      0.58 %            8.019575e-01
 http/simple.js res="normal" c=50 chunks=1 len=102400 type="bytes" benchmarker="wrk"     319.43 %        *** 1.099052e-27
 http/simple.js res="normal" c=50 chunks=1 len=4 type="buffer" benchmarker="wrk"           0.23 %            8.886316e-01
 http/simple.js res="normal" c=50 chunks=1 len=4 type="bytes" benchmarker="wrk"           -3.08 %            1.276294e-01
 http/simple.js res="normal" c=50 chunks=4 len=1024 type="buffer" benchmarker="wrk"        2.05 %            1.916095e-01
 http/simple.js res="normal" c=50 chunks=4 len=1024 type="bytes" benchmarker="wrk"      1376.72 %        *** 5.568434e-35
 http/simple.js res="normal" c=50 chunks=4 len=102400 type="buffer" benchmarker="wrk"     -1.57 %            5.306198e-01
 http/simple.js res="normal" c=50 chunks=4 len=102400 type="bytes" benchmarker="wrk"       3.76 %            5.205095e-02
 http/simple.js res="normal" c=50 chunks=4 len=4 type="buffer" benchmarker="wrk"          -2.78 %            1.683912e-01
 http/simple.js res="normal" c=50 chunks=4 len=4 type="bytes" benchmarker="wrk"         1409.81 %        *** 3.412588e-30

CI: https://ci.nodejs.org/job/node-test-pull-request/8060/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/789/

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

http

mscdex · 2017-05-16T03:50:13Z

Thoughts @nodejs/collaborators ?

ronkorving · 2017-05-16T05:30:23Z

I would mark this semver-major. I can imagine code out there on the receiving-end may depend on packets containing that first chunk. Not a good thing, but probably best to assume that exists.

thefourtheye · 2017-05-16T05:51:18Z

lib/_http_outgoing.js

@@ -78,6 +78,9 @@ utcDate._onTimeout = function _onTimeout() {
 };


+function noopPendingOutput(amount) {}


Mmmm, I thought our linter would complain about amount. It didn't.

AndreasMadsen

The AsyncHooks changes doesn't appear to have anything to do with this optimization, is there another PR or can you comment on why these changes were made?

edit: I see #13045 now. I'm not really comfortable with the socket._handle.asyncReset change until we understand why.

AndreasMadsen · 2017-05-16T06:27:53Z

lib/_http_agent.js

@@ -167,7 +167,8 @@ Agent.prototype.addRequest = function addRequest(req, options, port/*legacy*/,
    // we have a free socket, so use that.
    var socket = this.freeSockets[name].shift();
    // Assign the handle a new asyncId and run any init() hooks.
-    socket._handle.asyncReset();
+    if (socket._handle.asyncReset)


Why is this necessary?

Might not be necessary. At Least for the TLS case.
Ref #13092

AndreasMadsen · 2017-05-16T06:28:44Z

lib/_http_agent.js

@@ -182,7 +183,7 @@ Agent.prototype.addRequest = function addRequest(req, options, port/*legacy*/,
    // If we are under maxSockets create a new one.
    this.createSocket(req, options, function(err, newSocket) {
      if (err) {
-        nextTick(newSocket._handle.getAsyncId(), function() {
+        process.nextTick(function() {


Is this because the newSocket._handle isn't set when an error occurs?

mscdex · 2017-05-16T07:02:51Z

@AndreasMadsen Pay no attention to the async hooks workaround commit as it's temporary. I added it so that citgm and the like will work for this PR.

refack · 2017-05-16T13:13:56Z

lib/_http_outgoing.js

@@ -117,7 +120,7 @@ function OutgoingMessage() {
  this._header = null;
  this[outHeadersKey] = null;

-  this._onPendingData = null;
+  this._onPendingData = noopPendingOutput;


Since you don't need it's name to unregister why not just () => {}?

To avoid creating a new noop for each response.

refack · 2017-05-16T13:17:18Z

lib/_http_outgoing.js

-      this.outputEncodings.unshift('latin1');
-      this.outputCallbacks.unshift(null);
-      this.outputSize += this._header.length;
-      if (typeof this._onPendingData === 'function')


I like the "polymorphic" approach 👍
Question is the noop call faster than the if (typeof

I didn't measure it by itself, but it should be to some degree since it no longer has to execute a conditional before calling the function.

refack · 2017-05-16T13:20:01Z

lib/_http_outgoing.js

  return false;
-};
+}


Isn't this the end of OutgoingMessage.prototype._send = function _send, so should have ;

No, this is the end of _writeRaw() which uses a function declaration, so there is no semicolon needed.

refack · 2017-05-16T13:35:59Z

test/parallel/test-http-abort-client.js

@@ -37,6 +37,7 @@ server.listen(0, common.mustCall(function() {
    headers: { connection: 'keep-alive' }
  }, common.mustCall(function(res) {
    server.close();
+    serverRes.destroy();


~~What is the benefit of moving it here?~~
Found the comment.

refack

Some comments and quastions

refack · 2017-05-16T21:15:06Z

I'm +1, since except for the performance, IMHO it makes the code more readable.

this behavioral change actually brings it in line with what happens when writing a first Buffer chunk

and more consistent.

mscdex · 2017-05-22T20:02:33Z

Thoughts on semver-ness @nodejs/ctc ?

jasnell · 2017-05-23T03:46:42Z

hmm... really hard to say. Apps really shouldn't be depending on the data coming with the header. I think I'm ok with this as a patch.

mcollina · 2017-05-23T06:30:25Z

Given some recent digging I did, I would be cautious. I would say semver-patch, but don't backport to LTS for several months (if at all).

trevnorris · 2017-05-23T06:59:34Z

lib/_http_outgoing.js

+      var header = this._header;
+      if (this.output.length === 0) {
+        this.output = [header];
+        this.outputEncodings = ['latin1'];


General note on how we handle the response body. Browsers treat 'charset=latin1' as windows-1252, which is problematic. Example:

const headers = 'HTTP/1.1 200 OK\r\n' + 'Content-Type: text/html; charset=latin1\r\n' + 'Content-Length: 2\r\n\r\n' + // Technically 0x83 is a control code, but browsers don't see it that way. '\u0083\n'; const data = Buffer.from(headers, 'latin1'); require('net').createServer(c => c.end(data)).listen(8778);

Hit that with the browser and you'll see ƒ, not a control character symbol.

jasnell · 2017-05-23T14:55:35Z

semver-patch with no backporting works for me.

mscdex · 2017-05-25T13:16:43Z

semver-patch with no backporting works for me.

@jasnell Isn't that effectively semver-major then, or were you thinking about landing it in v8.0.0?

mscdex · 2017-05-25T13:17:53Z

Any reviews/approvals for this PR @nodejs/collaborators ?

jasnell · 2017-05-25T13:24:29Z

@mscdex ... not necessarily because after we give it a few months we may decide that it's safe to go ahead and pull back.

mscdex · 2017-05-26T08:33:14Z

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/8317/

PR-URL: nodejs#13013 Reviewed-By: James M Snell <[email protected]>

PR-URL: #13013 Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 13, 2017

mscdex added the performance Issues and PRs related to the performance of Node.js. label May 13, 2017

mscdex force-pushed the http-outgoing-string-perf branch from 24d3a7e to 171ad41 Compare May 16, 2017 02:40

thefourtheye reviewed May 16, 2017

View reviewed changes

AndreasMadsen reviewed May 16, 2017

View reviewed changes

mscdex added the wip Issues and PRs that are still a work in progress. label May 16, 2017

refack reviewed May 16, 2017

View reviewed changes

mscdex force-pushed the http-outgoing-string-perf branch from 171ad41 to fcde51c Compare May 20, 2017 03:53

mscdex removed the wip Issues and PRs that are still a work in progress. label May 20, 2017

mscdex force-pushed the http-outgoing-string-perf branch from fcde51c to 3251353 Compare May 20, 2017 03:54

trevnorris reviewed May 23, 2017

View reviewed changes

jasnell approved these changes May 25, 2017

View reviewed changes

mscdex added dont-land-on-v4.x labels May 26, 2017

mscdex force-pushed the http-outgoing-string-perf branch from 3251353 to eb7c38d Compare May 26, 2017 08:32

http: improve outgoing string write performance

a10bdb5

PR-URL: nodejs#13013 Reviewed-By: James M Snell <[email protected]>

mscdex force-pushed the http-outgoing-string-perf branch from eb7c38d to a10bdb5 Compare May 26, 2017 10:36

mscdex merged commit a10bdb5 into nodejs:master May 26, 2017

mscdex deleted the http-outgoing-string-perf branch May 26, 2017 10:40

jasnell pushed a commit that referenced this pull request May 28, 2017

http: improve outgoing string write performance

2264d9d

PR-URL: #13013 Reviewed-By: James M Snell <[email protected]>

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

andrewjjenkins mentioned this pull request Aug 2, 2017

HTTP OutgoingMessage _send in two packets when a Buffer is written #7914

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: improve outgoing string write performance #13013

http: improve outgoing string write performance #13013

mscdex commented May 13, 2017 •

edited

Loading

mscdex commented May 16, 2017

ronkorving commented May 16, 2017

thefourtheye May 16, 2017 •

edited

Loading

AndreasMadsen left a comment •

edited

Loading

AndreasMadsen May 16, 2017

refack May 18, 2017

AndreasMadsen May 16, 2017

mscdex commented May 16, 2017

refack May 16, 2017

mscdex May 16, 2017

refack May 16, 2017

mscdex May 16, 2017

refack May 16, 2017

mscdex May 16, 2017

refack May 16, 2017 •

edited

Loading

refack left a comment

refack commented May 16, 2017

mscdex commented May 22, 2017

jasnell commented May 23, 2017

mcollina commented May 23, 2017 •

edited

Loading

trevnorris May 23, 2017

jasnell commented May 23, 2017

mscdex commented May 25, 2017

mscdex commented May 25, 2017

jasnell commented May 25, 2017

mscdex commented May 26, 2017

		@@ -78,6 +78,9 @@ utcDate._onTimeout = function _onTimeout() {
		};


		function noopPendingOutput(amount) {}

http: improve outgoing string write performance #13013

http: improve outgoing string write performance #13013

Conversation

mscdex commented May 13, 2017 • edited Loading

Checklist

Affected core subsystem(s)

mscdex commented May 16, 2017

ronkorving commented May 16, 2017

thefourtheye May 16, 2017 • edited Loading

Choose a reason for hiding this comment

AndreasMadsen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mscdex commented May 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refack May 16, 2017 • edited Loading

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

refack commented May 16, 2017

mscdex commented May 22, 2017

jasnell commented May 23, 2017

mcollina commented May 23, 2017 • edited Loading

Choose a reason for hiding this comment

jasnell commented May 23, 2017

mscdex commented May 25, 2017

mscdex commented May 25, 2017

jasnell commented May 25, 2017

mscdex commented May 26, 2017

mscdex commented May 13, 2017 •

edited

Loading

thefourtheye May 16, 2017 •

edited

Loading

AndreasMadsen left a comment •

edited

Loading

refack May 16, 2017 •

edited

Loading

mcollina commented May 23, 2017 •

edited

Loading