test: replace port in dgram send address types test #13007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
May 13, 2017
| assert.throws(() => { | ||
| client.send(buf, port, true); | ||
| }, expectedError); | ||
| const onMessage = common.mustCall((err, bytes) => { |
There was a problem hiding this comment.
Nit: can you please move this at the top of the file? before creating the socket.
lpinca
reviewed
May 13, 2017
| assert.strictEqual(bytes, buf.length); | ||
| }, 6); | ||
|
|
||
| const expectedError = |
lpinca
approved these changes
May 13, 2017
Replaced common.PORT in the following test. test-dgram-send-address-types.js Ref: #12376
|
@lpinca All done, I moved those two items towards the top of the file. |
cjihrig
approved these changes
May 14, 2017
|
Landed in 281de19. |
lpinca
pushed a commit
that referenced
this pull request
May 22, 2017
Remove common.PORT from test-dgram-send-address-types to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #13007 Refs: #12376 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
64 tasks
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Remove common.PORT from test-dgram-send-address-types to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #13007 Refs: #12376 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Remove common.PORT from test-dgram-send-address-types to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #13007 Refs: #12376 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced common.PORT in the following test.
test-dgram-send-address-types.js
Ref: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram