Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded string splitting #12992

Closed
wants to merge 1 commit into from
Closed

test: remove unneeded string splitting #12992

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Some more readability with low overheads.

@vsemozhetbyt vsemozhetbyt added the test Issues and PRs related to the tests. label May 12, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8040/

One ARM failure seems unrelated.

@vsemozhetbyt
Copy link
Contributor Author

@addaleax
Copy link
Member

Landed in 88d2e69

@addaleax addaleax closed this May 15, 2017
addaleax pushed a commit that referenced this pull request May 15, 2017
PR-URL: #12992
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Luca Maraschi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@vsemozhetbyt vsemozhetbyt deleted the no-splitting branch May 15, 2017 12:20
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
PR-URL: nodejs#12992
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Luca Maraschi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jun 22, 2017
PR-URL: #12992
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Luca Maraschi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #12992
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Luca Maraschi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants