Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add common.mustCall() to NAPI exception test #12959

Closed
wants to merge 1 commit into from
Closed

test: add common.mustCall() to NAPI exception test #12959

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 11, 2017

Use common.mustCall() to confirm that function is invoked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
test: add common.mustCall() to NAPI exception test
77222b1 
Use `common.mustCall()` to confirm that function is invoked.
@Trott Trott added the test Issues and PRs related to the tests. label May 11, 2017
@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels May 11, 2017
@Trott
Copy link
Member Author

Trott commented May 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8056/

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2017
@Trott
test: add common.mustCall() to NAPI exception test
9516aa1 
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 13, 2017

Landed in 9516aa1

@Trott Trott closed this May 13, 2017
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@Trott
test: add common.mustCall() to NAPI exception test
feebd70 
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@Trott
test: add common.mustCall() to NAPI exception test
bdd1375 
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@Trott @MylesBorins
test: add common.mustCall() to NAPI exception test
263a633 
Use `common.mustCall()` to confirm that function is invoked.

Backport-PR-URL: #19447
PR-URL: #12959
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
@Trott Trott deleted the napi-noop branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @thefourtheye @addaleax @cjihrig @BridgeAR @gibfahn @nodejs-github-bot