Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace port in dgram cb length test #12943

Closed
wants to merge 1 commit into from
Closed

test: replace port in dgram cb length test #12943

wants to merge 1 commit into from

Conversation

arturgvieira-zz
Copy link

@arturgvieira-zz arturgvieira-zz commented May 10, 2017

Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2017
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label May 10, 2017
@arturgvieira-zz arturgvieira-zz changed the title test: remove common.PORT from test test: remove common.PORT in dgram cb test May 10, 2017
@arturgvieira-zz arturgvieira-zz changed the title test: remove common.PORT in dgram cb test test: replace port in dgram cb length test May 10, 2017
@arturgvieira-zz arturgvieira-zz changed the title test: replace port in dgram cb length test test: move to sequential dgram cb length test May 10, 2017
@arturgvieira-zz arturgvieira-zz deleted the commonPort05-branch branch May 11, 2017 05:52
@arturgvieira-zz arturgvieira-zz restored the commonPort05-branch branch May 11, 2017 05:54
@lpinca
Copy link
Member

lpinca commented May 11, 2017

For anyone reviewing, see discussion in #12929.

@arturgvieira-zz arturgvieira-zz changed the title test: move to sequential dgram cb length test test: replace port in dgram cb length test May 11, 2017
@@ -38,4 +38,4 @@ const messageSent = common.mustCall(function messageSent(err, bytes) {
client.close();
});

client.send(buf, offset, len, common.PORT, '127.0.0.1', messageSent);
client.bind(0, () => client.send(buf, offset, len, client.address().port, '127.0.0.1', messageSent));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long line.

@arturgvieira-zz
Copy link
Author

All done, wrapped arguments to shorten line length.

@lpinca
Copy link
Member

lpinca commented May 12, 2017

@arturgvieira-zz
Copy link
Author

I'll run make lint and correct the errors.

Replaced common.Port in the following test.
test-dgram-send-callback-buffer-length.js

Ref: #12376
@lpinca
Copy link
Member

lpinca commented May 12, 2017

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@lpinca
Copy link
Member

lpinca commented May 22, 2017

Landed in dd3c227.

@lpinca lpinca closed this May 22, 2017
lpinca pushed a commit that referenced this pull request May 22, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: #12943
Refs: #12376
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell pushed a commit that referenced this pull request May 23, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: #12943
Refs: #12376
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell pushed a commit that referenced this pull request May 23, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: #12943
Refs: #12376
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: #12943
Refs: #12376
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants