test: add a simple abort check in windows #12914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
approved these changes
May 9, 2017
refack
approved these changes
May 9, 2017
gibfahn
approved these changes
May 9, 2017
|
This looks great, if you could add a two line summary of what the test tests that would be ideal (see the writing tests guide). |
|
@gibfahn Done. Added summary. Thanks |
cjihrig
approved these changes
May 9, 2017
| if (process.argv[2] === 'child') { | ||
| process.abort(); | ||
| } else { | ||
| const child = spawn(process.argv[0], [process.argv[1], 'child']); |
There was a problem hiding this comment.
Nit, but could you use process.execPath and __filename instead of the argv values? I think it's a little more readable.
| const assert = require('assert'); | ||
|
|
||
| // This test makes sure that an aborted node process | ||
| // exits with code 3 in windows. |
There was a problem hiding this comment.
Done. Thanks.
| // This test makes sure that an aborted node process | ||
| // exits with code 3 in windows. | ||
| // Spawn a child, force an abort, and then check the | ||
| // exit code in the parent. Assert on code and signal |
There was a problem hiding this comment.
You can probably drop the last sentence.
raise(SIGABRT) or CRT abort causes exit code 3 and null signal in windows. Looks like this simple assertion is not present in windows. Make this assertion.
gireeshpunathil
approved these changes
May 10, 2017
|
Landed in 642bd4d |
refack
pushed a commit
that referenced
this pull request
May 12, 2017
raise(SIGABRT) or CRT abort causes exit code 3 and null signal in windows. Looks like this simple assertion is not present in windows. Make this assertion. PR-URL: #12914 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
post land CI:https://ci.nodejs.org/job/node-test-commit/9853/ |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
raise(SIGABRT) or CRT abort causes exit code 3 and null signal in windows. Looks like this simple assertion is not present in windows. Make this assertion. PR-URL: nodejs#12914 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
|
does this make sense for v6.x? |
Yes. (just checked it passes as is). |
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
raise(SIGABRT) or CRT abort causes exit code 3 and null signal in windows. Looks like this simple assertion is not present in windows. Make this assertion. PR-URL: #12914 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Working with @gireeshpunathil, I came up with this PR following @refack's suggestion
in #12856 . Though associated with that, this test is logically independent of that PR,
and does not need to co-exist with that one, and hence a separate one.
Make a simple assertion that Windows aborts with exit code 3.