Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused testpy code #12844

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented May 5, 2017

The temporary directory for tests is managed in the JS common module.
Remove unused variable from testpy that is legacy from when it was
managed in the Python test harness.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

The temporary directory for tests is managed in the JS `common` module.
Remove unused variable from `testpy` that is legacy from when it was
managed in the Python test harness.
@Trott Trott added the test Issues and PRs related to the tests. label May 5, 2017
@DavidCai1111
Copy link
Member

Trott added a commit to Trott/io.js that referenced this pull request May 8, 2017
The temporary directory for tests is managed in the JS `common` module.
Remove unused variable from `testpy` that is legacy from when it was
managed in the Python test harness.

PR-URL: nodejs#12844
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 8, 2017

Landed in dc4313c

@Trott Trott closed this May 8, 2017
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
The temporary directory for tests is managed in the JS `common` module.
Remove unused variable from `testpy` that is legacy from when it was
managed in the Python test harness.

PR-URL: nodejs#12844
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
The temporary directory for tests is managed in the JS `common` module.
Remove unused variable from `testpy` that is legacy from when it was
managed in the Python test harness.

PR-URL: #12844
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
The temporary directory for tests is managed in the JS `common` module.
Remove unused variable from `testpy` that is legacy from when it was
managed in the Python test harness.

PR-URL: #12844
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
@Trott Trott deleted the init-tmpdir branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants