Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js2c: fix module id generation on windows #1281

Merged
merged 1 commit into from
Mar 27, 2015
Merged

js2c: fix module id generation on windows #1281

merged 1 commit into from
Mar 27, 2015

Commits on Mar 27, 2015

  1. js2c: fix module id generation on windows 

    Fix a regression that was introduced in commit 2db758c ("iojs: introduce
internal modules") where the computed id for "config.gypi" on Windows
was not "config" but an empty string.

With an empty string, the build succeeds but the binary is unusable:
startup.processConfig() in src/node.js chokes on the missing .config
property.

PR-URL: nodejs#1281
Reviewed-By: Vladimir Kurchatkin <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 27, 2015
    Configuration menu
    Copy the full SHA
    36f017a View commit details
    Browse the repository at this point in the history