Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unused code from test.py #12806

Closed
wants to merge 1 commit into from
Closed

tools: remove unused code from test.py #12806

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@Trott Trott added the tools Issues and PRs related to the tools directory. label May 3, 2017
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels May 3, 2017
@Trott
Copy link
Member Author

Trott commented May 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7820/

refack
refack approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless you

@refack
Copy link
Contributor

refack commented May 3, 2017 •
edited
Loading

Just from interest, how did you get the "unused" set?

@Trott
Copy link
Member Author

Trott commented May 3, 2017

Just from interest, how did you get the "unused" set?

vulture tools/test.py test/*/testcfg.py

@refack
Copy link
Contributor

refack commented May 4, 2017

vulture tools/test.py test/*/testcfg.py

Ohhhhh when I get the chance I'm gonna do this to GYP. Oh yeah do it so hard 🤣

Trott added a commit to Trott/io.js that referenced this pull request May 5, 2017
@Trott
tools: remove unused code from test.py
53c88fa 
PR-URL: nodejs#12806
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 5, 2017

Landed in 53c88fa

@Trott Trott closed this May 5, 2017
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@Trott
tools: remove unused code from test.py
4950185 
PR-URL: nodejs#12806
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
@Trott @gibfahn
tools: remove unused code from test.py
c139b07 
PR-URL: #12806
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@Trott @gibfahn
tools: remove unused code from test.py
7d441d7 
PR-URL: #12806
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@Trott @MylesBorins
tools: remove unused code from test.py
95d13d5 
PR-URL: #12806
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@Trott Trott deleted the rm-unused-python-code branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @refack @jasnell @cjihrig @gibfahn @nodejs-github-bot