Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: remove eslint comments" #12743

Closed
wants to merge 1 commit into from
Closed

Revert "test: remove eslint comments" #12743

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This reverts commit 8d1f15b to preserve the original WPT code.

Refs: https://github.com/nodejs/node/pull/12669/files/b2c7a51dd7542add59f08a8e9361ac4715c7f5ab#r114009488

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, url-whatwg

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 29, 2017
@joyeecheung joyeecheung mentioned this pull request Apr 29, 2017
Merged
3 tasks
@joyeecheung joyeecheung requested a review from cjihrig April 29, 2017 15:39
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7745/

@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Apr 29, 2017
@mscdex
Copy link
Contributor

mscdex commented Apr 29, 2017 •
edited
Loading

I agree with the referenced comments that we should include some text saying not to modify and why.

Trott
Trott approved these changes Apr 29, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree that adding a comment would be good to this and the other whatwg-url tests, but that should probably be a separate PR and let this one be a straightforward revert of a single commit.

@joyeecheung
Copy link
Member Author

Landed in 9f7b549, thanks!

@joyeecheung joyeecheung closed this May 2, 2017
joyeecheung added a commit that referenced this pull request May 2, 2017
@joyeecheung
Revert "test: remove eslint comments"
9f7b549 
This reverts commit 8d1f15b
to preserve the original WPT code.

PR-URL: #12743
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request May 2, 2017
Closed
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@joyeecheung
Revert "test: remove eslint comments"
cbf3e16 
This reverts commit 8d1f15b
to preserve the original WPT code.

PR-URL: nodejs#12743
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Reverts #12669, which was dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @mscdex @gibfahn @jasnell @Trott @watilde @cjihrig @nodejs-github-bot