Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: decouple sidebar scrolling #1274

Closed
wants to merge 5 commits into from
Closed

doc: decouple sidebar scrolling #1274

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa59a63
doc: decouple sidebar scrolling
silverwind Mar 26, 2015
12f6b41
Add fade-out to indicate scrolling area
silverwind Mar 27, 2015
73be958
Make the gradient click-through
silverwind Mar 27, 2015
97e6ed0
Slightly less padding
silverwind Mar 28, 2015
83fb82c
Add left:0 to be safe on positioning
silverwind Mar 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions doc/api_assets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,19 @@ span.type {

#column2.interior {
width: 234px;
float: left;
position: fixed;
height: 100%;
overflow-y: scroll;
}

#column2.interior:after {
content: '';
position: fixed;
bottom: 0;
width: 234px;
height: 5em;
background: linear-gradient(rgba(242,245,240, 0), rgba(242,245,240, 1));
pointer-events: none;
}

#column2 ul {
Expand All @@ -360,7 +372,7 @@ span.type {
margin-top: 1.25em;
background: #f2f5f0;
margin-bottom: 0;
padding-bottom: 2.5em;
padding-bottom: 5em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of how large this padding is, could we do with something smaller, maybe 2em?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it needs to be big now with the gradient, or else items would still be faded out when scrolled to the end. I think 4em is the lower limit, I'll experiment a bit.

}

#column2 ul li {
Expand Down