-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove obsolete lint comment #12659
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eslint-disable comment in test-repl.js appears to have been restored by accident while restoring other comments. Remove it.
Trott
added
repl
Issues and PRs related to the REPL subsystem.
test
Issues and PRs related to the tests.
labels
Apr 26, 2017
LGTM |
cjihrig
approved these changes
Apr 26, 2017
refack
approved these changes
Apr 26, 2017
aqrln
approved these changes
Apr 26, 2017
gibfahn
approved these changes
Apr 26, 2017
jasnell
approved these changes
Apr 26, 2017
lpinca
approved these changes
Apr 26, 2017
LGTM Landed in bda34bd |
addaleax
pushed a commit
that referenced
this pull request
Apr 26, 2017
The eslint-disable comment in test-repl.js appears to have been restored by accident while restoring other comments. Remove it. PR-URL: #12659 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
3 tasks
Based on #10155 which is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test repl