Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete lint comment #12659

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 26, 2017

The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.
@Trott Trott added repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Apr 26, 2017
@Trott
Copy link
Member Author

Trott commented Apr 26, 2017

@mscdex
Copy link
Contributor

mscdex commented Apr 26, 2017

LGTM

@addaleax
Copy link
Member

LGTM

Landed in bda34bd

@addaleax addaleax closed this Apr 26, 2017
addaleax pushed a commit that referenced this pull request Apr 26, 2017
The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.

PR-URL: #12659
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Based on #10155 which is dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants