test: dynamic port in dgram tests

[sebastianplesciuc]

Removed common.PORT from:

• test-dgram-close-in-listening
• test-dgram-close-is-not-callback
• test-dgram-close
• test-dgram-exclusive-implicit-bind
• test-dgram-oob-buffer

This is required in order to eliminate the possibility of port collision in parallel tests.

Refs: #12376

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

[sebastianplesciuc]

I don't know if this is the most elegant solution. My reasoning was that if we actually send data on UDP we might as well send it to a port we own in that specific test. Or, if we need to send it to a closed port, to call send() in the callback of another socket's close().

Thoughts?

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/7636/

[addaleax]

Landed in d289678, thanks for the PR!

[gibfahn]

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

[sebastianplesciuc]

@gibfahn PR: #13792

Let me know if it's ok. If this shouldn't be backported then I'll close the PR.

[gibfahn]

Let me know if it's ok. If this shouldn't be backported then I'll close the PR.

Looks good to me, thanks for doing it!