backport: 11665 to v7 #12614
Closed
backport: 11665 to v7 #12614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
evanlucas
force-pushed
the
v7.x-staging
branch
2 times, most recently
from
d4ceb59
to
69a8053
Compare
Including: * Move async *stat() functions to FillStatsArray() now used by the sync *stat() functions * Avoid creating fs.Stats instances for implicit async/sync *stat() calls used in various fs functions * Store reference to Float64Array data on C++ side for easier/faster access, instead of passing from JS to C++ on every async/sync *stat() call
Including: * Skip URL instance check for common (string) cases * Avoid regexp on non-Windows platforms when parsing the root of a path * Skip call to `getOptions()` in common case where no `options` is passed * Avoid `hasOwnProperty()`
|
CI again: https://ci.nodejs.org/job/node-test-pull-request/7867/ /cc @nodejs/collaborators It'd be nice to get this landed soon if everyone agrees/approves of the changes since it fixes potential issues with |
|
ping @nodejs/collaborators |
jasnell
approved these changes
May 29, 2017
|
Closing this as AFAIK node v7.x is now an unsupported branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #11665 + a few non-semver-major changes (specifically only to
fs.realpathSync()andfs.realpath()) from #10789.#11665 was initially labeled as semver-major by me as I typically like to err on the side of caution because of the nature of some of the changes. However, some have expressed interest in downgrading it to a semver-minor to allow (a more straightforward backport of) a necessary fix for a discrepancy that exists currently in v7.x because of the way
fs.Statsvalues are generated forfs.stat()vsfs.statSync()for example.Landing this should fix the issue described in #12419.
/cc @nodejs/ctc
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)