Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added relative path to accommodate limit #12601

Closed
wants to merge 3 commits into from
Closed

test: Added relative path to accommodate limit #12601

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a42ed
test: Added relative path to accommodate limit
Apr 22, 2017
b1f370b
test: improved call to path.relative()
Apr 27, 2017
d97a6d8
test: improved comments
Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/parallel/test-net-connect-options-fd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
const common = require('../common');
const assert = require('assert');
const net = require('net');
const path = require('path');
const Pipe = process.binding('pipe_wrap').Pipe;

if (common.isWindows) {
Expand Down Expand Up @@ -32,7 +33,8 @@ const forAllClients = (cb) => common.mustCall(cb, CLIENT_VARIANTS);

// Test Pipe fd is wrapped correctly
{
const prefix = `${common.PIPE}-net-connect-options-fd`;
const prefix = path.relative(`${common.PIPE}-net-connect-options-fd`,
`${__dirname}-net-connect-options-fd`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be this instead:

const prefix = path.relative('.', `${common.PIPE}-net-connect-options-fd`);

Simpler, and I think it will fix the problems we're seeing on CI.

const serverPath = `${prefix}-server`;
let counter = 0;
let socketCounter = 0;
Expand Down