-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 4.5.0 #12480
deps: upgrade npm to 4.5.0 #12480
Conversation
Just fyi, the new semver-major cutoff date for Node 8 is May 9th, and the target release date is May 30th. It sounds like that might just be doable? |
*Full Log*
|
Edit: some modifications to the test shows it is indeed the same error. log
|
@iarna Looks like there is some issue with this PR, the previous npm runs the tests fine for me on |
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. Refs: nodejs#12480
Great stuff on npm 5. Hopefully we'll get that added to Node.js whenever it's considered stable! |
|
ping @nodejs/npm |
Sorry about that, it seems something in the Node.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, LGTM.
Thanks, landed in 0084260! |
PR-URL: #12480 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sorry, didn’t catch it, but like #12479 this should not have landed just yet, with node-gyp v3.6.0 in it … I’ve added all dont-land labels, including the one for v8.x for now |
@addaleax except for |
@refack yea, and if somebody wants to pull the dont-land labels, sure. my code is fixed now (thanks again! :)) 😄 Basically, people in the other thread seemed to agree with #12479 (comment) – I don’t feel too strongly either way, but I would like to avoid publishing Node versions with known regressions unless we have a sensible reason to do so. |
I'm ±0 |
[email protected] is out, can someone put in a PR to npm for this pls? |
@rvagg I should be able to do that, thanks for doing the release! edit: npm/npm#16484 |
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: #12490 Refs: #12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: nodejs/node#12490 Refs: nodejs/node#12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: nodejs/node#12490 Refs: nodejs/node#12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: #12490 Refs: #12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: #12490 Refs: #12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: #12490 Refs: #12480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
deps
Description of Changes
npm ls
output to be complete. Previously the list was trimmed. Additionally deduplicated dependencies are now listed with a note that they were deduped.Also a bunch of bug fixes and minor performance improvements.
(FYI: npm@5 has just [this day] entered internal testing at npm. We should have it out to public testing in a week or two. It'll have a longer-than-usual public test period due to it's larger-than-usual changes. The biggest thing it brings is massive speed improvements, so we're pretty excited about it. [On the order of 160s in npm@4 and 30s in npm@5.])
Changelogs
v4.5.0
v4.4.4
v4.4.3
v4.4.2
v4.4.1
v4.4.0
v4.3.0
r: @Fishrock123
r: @addaleax
r: @jasnell