Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 4.5.0 #12480

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 4.5.0 #12480

wants to merge 1 commit into from

Conversation

iarna
Copy link
Member

@iarna iarna commented Apr 18, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of Changes
  • Update notifications—when a newer version of npm is released you'll get a one-time notice along with instructions on how to upgrade.
  • Uses the new registry feature that returns trimmed package metadata. We're calling these corgis. This is a substantial reduction for older modules with lots of releases. For example, for npm itself it reduces the 416k of gzip compressed JSON to 24k.
  • Error messages have been substantially trimmed to make it easier to figure out what went wrong.
  • Change npm ls output to be complete. Previously the list was trimmed. Additionally deduplicated dependencies are now listed with a note that they were deduped.
  • Installations in directories stored on OverlayFS (common in Docker configurations) are now supported.
  • Concurrency limits were added to be kinder to folks with limited connections or hardware.
  • Warn if you have a module listed in both dependencies and devDependencies.
  • The new node-gyp!

Also a bunch of bug fixes and minor performance improvements.

(FYI: npm@5 has just [this day] entered internal testing at npm. We should have it out to public testing in a week or two. It'll have a longer-than-usual public test period due to it's larger-than-usual changes. The biggest thing it brings is massive speed improvements, so we're pretty excited about it. [On the order of 160s in npm@4 and 30s in npm@5.])

Changelogs

r: @Fishrock123
r: @addaleax
r: @jasnell

@iarna iarna added dont-land-on-v4.x npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 18, 2017
@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 18, 2017
@addaleax
Copy link
Member

npm@5 has just [this day] entered internal testing at npm

Just fyi, the new semver-major cutoff date for Node 8 is May 9th, and the target release date is May 30th. It sounds like that might just be doable?

@Fishrock123
Copy link
Contributor

make test-npm fails for me... 🤔

[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.restparam
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'bluebird'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Jeremiah/Documents/node/test-npm/npm-cache/_logs/2017-04-18T15_27_49_738Z-debug.log
make: *** [test-npm] Error 1

*Full Log*
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
  touch 4916121b716d544d86e0e2e63624385df011b23c.intermediate
  LD_LIBRARY_PATH=/Users/Jeremiah/Documents/node/out/Release/lib.host:/Users/Jeremiah/Documents/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/src/inspector; mkdir -p /Users/Jeremiah/Documents/node/out/Release/obj/gen/src/inspector/protocol /Users/Jeremiah/Documents/node/out/Release/obj/gen/include/inspector; python ../../third_party/inspector_protocol/CodeGenerator.py --jinja_dir ../../third_party --output_base "/Users/Jeremiah/Documents/node/out/Release/obj/gen/src/inspector" --config inspector_protocol_config.json
rm 4916121b716d544d86e0e2e63624385df011b23c.intermediate
if [ ! -r node -o ! -L node ]; then ln -fs out/Release/node node; fi
NODE=./node tools/test-npm.sh
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/JSONStream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/JSONStream/node_modules/jsonparse
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/JSONStream/node_modules/through
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/abbrev
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/ansi-regex
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/ansicolors
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/ansistyles
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/aproba
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/archy
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/asap
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/bluebird
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/call-limit
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/chownr
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/cmd-shim
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/graceful-fs
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mkdirp
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mkdirp/node_modules/minimist
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/columnify
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/strip-ansi
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/columnify/node_modules/wcwidth
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/columnify/node_modules/wcwidth/node_modules/defaults
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/columnify/node_modules/wcwidth/node_modules/defaults/node_modules/clone
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/config-chain
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/ini
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/config-chain/node_modules/proto-list
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/dezalgo
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/wrappy
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/editor
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fs-vacuum
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/path-is-inside
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/rimraf
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/fs.realpath
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/inflight
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/once
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/inherits
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/minimatch
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/minimatch/node_modules/brace-expansion
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/minimatch/node_modules/brace-expansion/node_modules/concat-map
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/glob/node_modules/path-is-absolute
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fs-write-stream-atomic
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/iferr
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/imurmurhash
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/buffer-shims
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/core-util-is
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/isarray
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/process-nextick-args
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/string_decoder
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readable-stream/node_modules/util-deprecate
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm/node_modules/fstream-ignore
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm/node_modules/fstream-ignore/node_modules/minimatch
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm/node_modules/fstream-ignore/node_modules/minimatch/node_modules/brace-expansion
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm/node_modules/fstream-ignore/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/fstream-npm/node_modules/fstream-ignore/node_modules/minimatch/node_modules/brace-expansion/node_modules/concat-map
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/has-unicode
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/hosted-git-info
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/init-package-json
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-package-arg
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/semver
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/init-package-json/node_modules/promzard
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read/node_modules/mute-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-package-json
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-package-json/node_modules/json-parse-helpfulerror
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-package-json/node_modules/json-parse-helpfulerror/node_modules/jju
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/normalize-package-data
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/normalize-package-data/node_modules/is-builtin-module
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/normalize-package-data/node_modules/is-builtin-module/node_modules/builtin-modules
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license/node_modules/spdx-correct
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license/node_modules/spdx-correct/node_modules/spdx-license-ids
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license/node_modules/spdx-expression-parse
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license/node_modules/spdx-expression-parse/node_modules/spdx-exceptions
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-license/node_modules/spdx-expression-parse/node_modules/spdx-license-ids
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-name
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/validate-npm-package-name/node_modules/builtins
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lazy-property
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lockfile
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._baseuniq
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._baseuniq/node_modules/lodash._createset
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._baseuniq/node_modules/lodash._root
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.clonedeep
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.union
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.uniq
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.without
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/concat-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/concat-stream/node_modules/typedarray
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/duplexify
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/duplexify/node_modules/end-of-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/duplexify/node_modules/end-of-stream/node_modules/once
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/duplexify/node_modules/stream-shift
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/end-of-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/end-of-stream/node_modules/once
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/flush-write-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/from2
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/parallel-transform
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/parallel-transform/node_modules/cyclist
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/pump
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/pumpify
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/stream-each
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/stream-each/node_modules/stream-shift
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/through2
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/mississippi/node_modules/through2/node_modules/xtend
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/move-concurrently
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/move-concurrently/node_modules/copy-concurrently
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/move-concurrently/node_modules/run-queue
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp/node_modules/minimatch
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp/node_modules/minimatch/node_modules/brace-expansion
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp/node_modules/minimatch/node_modules/brace-expansion/node_modules/balanced-match
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp/node_modules/minimatch/node_modules/brace-expansion/node_modules/concat-map
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/node-gyp/node_modules/nopt
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/are-we-there-yet
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/are-we-there-yet/node_modules/delegates
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/console-control-strings
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/object-assign
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/signal-exit
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/string-width
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/string-width/node_modules/code-point-at
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/string-width/node_modules/is-fullwidth-code-point
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/string-width/node_modules/is-fullwidth-code-point/node_modules/number-is-nan
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/supports-color
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/gauge/node_modules/wide-align
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npmlog/node_modules/set-blocking
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/osenv
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/osenv/node_modules/os-homedir
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/osenv/node_modules/os-tmpdir
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/aws-sign2
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/aws4
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/caseless
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/combined-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/combined-stream/node_modules/delayed-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/extend
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/forever-agent
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/form-data
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/form-data/node_modules/asynckit
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/mime-types
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/mime-types/node_modules/mime-db
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator/node_modules/ajv
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator/node_modules/ajv/node_modules/co
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator/node_modules/ajv/node_modules/json-stable-stringify
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator/node_modules/ajv/node_modules/json-stable-stringify/node_modules/jsonify
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/har-validator/node_modules/har-schema
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/hawk
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/hawk/node_modules/boom
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/hawk/node_modules/hoek
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/hawk/node_modules/cryptiles
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/hawk/node_modules/sntp
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/assert-plus
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/jsprim
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/jsprim/node_modules/extsprintf
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/jsprim/node_modules/json-schema
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/jsprim/node_modules/verror
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/asn1
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/assert-plus
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/bcrypt-pbkdf
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/tweetnacl
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/dashdash
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/ecc-jsbn
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/jsbn
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/getpass
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/node_modules/jodid25519
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/is-typedarray
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/isstream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/json-stringify-safe
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/oauth-sign
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/performance-now
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/qs
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/safe-buffer
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/stringstream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/tough-cookie
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/tough-cookie/node_modules/punycode
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/request/node_modules/tunnel-agent
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/uuid
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/tar
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/tar/node_modules/block-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/which
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/which/node_modules/isexe
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/nopt
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/nopt/node_modules/osenv
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/nopt/node_modules/osenv/node_modules/os-homedir
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/nopt/node_modules/osenv/node_modules/os-tmpdir
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/normalize-git-url
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-cache-filename
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-install-checks
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-registry-client
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-registry-client/node_modules/concat-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-registry-client/node_modules/concat-stream/node_modules/typedarray
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/retry
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/slide
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/npm-user-validate
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/opener
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-cmd-shim
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-installed
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/debuglog
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/readdir-scoped-modules
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-installed/node_modules/util-extend
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/read-package-tree
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/realize-package-specifier
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sha
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-object
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/from2
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/from2/node_modules/readable-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/from2/node_modules/readable-stream/node_modules/core-util-is
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/from2/node_modules/readable-stream/node_modules/isarray
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/from2/node_modules/readable-stream/node_modules/string_decoder
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/sorted-union-stream/node_modules/stream-iterate
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/text-table
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/uid-number
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/umask
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/unique-filename
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/unique-filename/node_modules/unique-slug
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/unpipe
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/ansi-align
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/ansi-align/node_modules/string-width
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/ansi-align/node_modules/string-width/node_modules/code-point-at
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/ansi-align/node_modules/string-width/node_modules/is-fullwidth-code-point
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/ansi-align/node_modules/string-width/node_modules/is-fullwidth-code-point/node_modules/number-is-nan
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/camelcase
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/chalk
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/chalk/node_modules/ansi-styles
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/chalk/node_modules/escape-string-regexp
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/chalk/node_modules/has-ansi
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/chalk/node_modules/supports-color
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/cli-boxes
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/string-width
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/string-width/node_modules/is-fullwidth-code-point
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/cross-spawn-async
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/cross-spawn-async/node_modules/lru-cache
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/cross-spawn-async/node_modules/lru-cache/node_modules/pseudomap
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/cross-spawn-async/node_modules/lru-cache/node_modules/yallist
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/is-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/npm-run-path
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/path-key
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/object-assign
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/term-size/node_modules/execa/node_modules/strip-eof
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/widest-line
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/widest-line/node_modules/string-width
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/widest-line/node_modules/string-width/node_modules/code-point-at
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/widest-line/node_modules/string-width/node_modules/is-fullwidth-code-point
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/boxen/node_modules/widest-line/node_modules/string-width/node_modules/is-fullwidth-code-point/node_modules/number-is-nan
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/configstore
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/configstore/node_modules/dot-prop
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/configstore/node_modules/dot-prop/node_modules/is-obj
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/configstore/node_modules/unique-string
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/configstore/node_modules/unique-string/node_modules/crypto-random-string
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/write-file-atomic
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/xdg-basedir
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/is-npm
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/create-error-class
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/create-error-class/node_modules/capture-stack-trace
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/duplexer3
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/get-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/is-redirect
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/is-retry-allowed
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/is-stream
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/lowercase-keys
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/safe-buffer
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/timed-out
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/unzip-response
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/url-parse-lax
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/got/node_modules/url-parse-lax/node_modules/prepend-http
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-auth-token
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-auth-token/node_modules/rc
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-auth-token/node_modules/rc/node_modules/deep-extend
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-auth-token/node_modules/rc/node_modules/minimist
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-auth-token/node_modules/rc/node_modules/strip-json-comments
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-url
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-url/node_modules/rc
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-url/node_modules/rc/node_modules/deep-extend
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-url/node_modules/rc/node_modules/minimist
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/latest-version/node_modules/package-json/node_modules/registry-url/node_modules/rc/node_modules/strip-json-comments
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/lazy-req
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/update-notifier/node_modules/semver-diff
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._baseindexof
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._bindcallback
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._cacheindexof
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._createcache
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash._getnative
[email protected] /Users/Jeremiah/Documents/node/test-npm/node_modules/lodash.restparam
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'bluebird'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Jeremiah/Documents/node/test-npm/npm-cache/_logs/2017-04-18T15_27_49_738Z-debug.log
make: *** [test-npm] Error 1

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 18, 2017

test/parallel/test-npm-install also fails:

Path: parallel/test-npm-install
assert.js:86
  throw new assert.AssertionError({
  ^
AssertionError: npm install got error code 1
    at ChildProcess.handleExit (/Users/Jeremiah/Documents/node/test/parallel/test-npm-install.js:56:10)
    at ChildProcess.<anonymous> (/Users/Jeremiah/Documents/node/test/common.js:461:15)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:196:12)
Command: out/Release/node /Users/Jeremiah/Documents/node/test/parallel/test-npm-install.js

Edit: some modifications to the test shows it is indeed the same error.

log
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'bluebird'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Jeremiah/Documents/node/test/tmp/npm-sandbox/home/.npm/_logs/2017-04-18T16_18_55_956Z-debug.log

assert.js:86
  throw new assert.AssertionError({
  ^
AssertionError: npm install got error code 1

@Fishrock123
Copy link
Contributor

@iarna Looks like there is some issue with this PR, the previous npm runs the tests fine for me on master.

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Apr 18, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

Refs: nodejs#12480
@Fishrock123 Fishrock123 self-assigned this Apr 18, 2017
@NawarA
Copy link

NawarA commented Apr 19, 2017

Great stuff on npm 5. Hopefully we'll get that added to Node.js whenever it's considered stable!

@Fishrock123
Copy link
Contributor

/Users/Jeremiah/Documents/node/test-npm/npm-cache/_logs/2017-04-21T15_53_33_277Z-debug.log Looks like:

0 info it worked if it ends with ok
1 verbose cli [ '/Users/Jeremiah/Documents/node/out/Release/node',
1 verbose cli   '/Users/Jeremiah/Documents/node/test-npm/cli.js',
1 verbose cli   'install',
1 verbose cli   '--ignore-scripts' ]
2 info using [email protected]
3 info using [email protected]
4 verbose stack Error: Cannot find module 'bluebird'
4 verbose stack     at Function.Module._resolveFilename (module.js:498:15)
4 verbose stack     at Function.Module._load (module.js:437:25)
4 verbose stack     at Module.require (module.js:526:17)
4 verbose stack     at require (internal/module.js:19:18)
4 verbose stack     at Object.<anonymous> (/Users/Jeremiah/Documents/node/test-npm/lib/utils/move.js:6:16)
4 verbose stack     at Module._compile (module.js:607:30)
4 verbose stack     at Object.Module._extensions..js (module.js:618:10)
4 verbose stack     at Module.load (module.js:516:32)
4 verbose stack     at tryModuleLoad (module.js:466:12)
4 verbose stack     at Function.Module._load (module.js:458:3)
5 verbose cwd /Users/Jeremiah/Documents/node/test-npm
6 verbose Darwin 16.5.0
7 verbose argv "/Users/Jeremiah/Documents/node/out/Release/node" "/Users/Jeremiah/Documents/node/test-npm/cli.js" "install" "--ignore-scripts"
8 verbose node v8.0.0-pre
9 verbose npm  v4.5.0
10 error code MODULE_NOT_FOUND
11 error Cannot find module 'bluebird'
12 verbose exit [ 1, true ]

@Fishrock123
Copy link
Contributor

ping @nodejs/npm

@iarna
Copy link
Member Author

iarna commented Apr 24, 2017

Sorry about that, it seems something in the Node.js .gitignore ended up ignoring deps/npm/node_modules/bluebird/js/release. (I've repushed with the missing files added.)

Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, LGTM.

@Fishrock123
Copy link
Contributor

Thanks, landed in 0084260!

Fishrock123 pushed a commit that referenced this pull request Apr 25, 2017
PR-URL: #12480
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@addaleax
Copy link
Member

Sorry, didn’t catch it, but like #12479 this should not have landed just yet, with node-gyp v3.6.0 in it … I’ve added all dont-land labels, including the one for v8.x for now

@refack
Copy link
Contributor

refack commented Apr 30, 2017

@addaleax except for lzma-native AFAIK there were no other reported regressions...
but someone should cut a 3.6.1
/cc @bnoordhuis @rvagg

@addaleax
Copy link
Member

@refack yea, and if somebody wants to pull the dont-land labels, sure. my code is fixed now (thanks again! :)) 😄

Basically, people in the other thread seemed to agree with #12479 (comment) – I don’t feel too strongly either way, but I would like to avoid publishing Node versions with known regressions unless we have a sensible reason to do so.

@refack
Copy link
Contributor

refack commented Apr 30, 2017

I'm ±0

@rvagg
Copy link
Member

rvagg commented Apr 30, 2017

[email protected] is out, can someone put in a PR to npm for this pls?

@addaleax
Copy link
Member

addaleax commented Apr 30, 2017

@rvagg I should be able to do that, thanks for doing the release!

edit: npm/npm#16484

@zkat zkat deleted the npm-4.5.0 branch April 30, 2017 23:06
@zkat zkat restored the npm-4.5.0 branch April 30, 2017 23:06
@jasnell jasnell mentioned this pull request May 11, 2017
BridgeAR pushed a commit that referenced this pull request Aug 26, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants