tests: remove common.PORT from shared,master,rr tests #12451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
reviewed
Apr 16, 2017
| worker2 = cluster.fork(); | ||
| worker2.on('online', function() { | ||
| conn = net.connect(common.PORT, common.mustCall(function() { | ||
| conn = net.connect(worker.port, common.mustCall(function() { |
There was a problem hiding this comment.
I would rename worker to address.
There was a problem hiding this comment.
Yeah, that makes sense. Changing.
|
@santigimeno Yes I saw the comment and I'm curious too, but I don't have access to another OS. |
santigimeno
approved these changes
Apr 16, 2017
There was a problem hiding this comment.
@tarunbatra I can confirm it also fails as expected with the new version of the test using [email protected] on OS.X. LGTM
|
@santigimeno great. Thanx! I'll try to use similar pattern in other test files. |
|
@santigimeno What should be preferred, more commits to this PR or a new PR for small changes to other files regarding the same issue #12376 ? |
|
@tarunbatra if the changes are similar I would group them, but as you prefer :). |
Files changed: * test/parallel/test-cluster-master-error.js * test/parallel/test-cluster-master-kill.js * test/parallel/test-cluster-net-send.js * test/parallel/test-cluster-rr-domain-listen.js * test/parallel/test-cluster-rr-ref.js * test/parallel/test-cluster-worker-no-exit.js Refs: #12376 PR_URL: #12451
tarunbatra
changed the title
64 tasks
ghost
approved these changes
Apr 17, 2017
lpinca
approved these changes
Apr 17, 2017
benjamingr
approved these changes
Apr 17, 2017
cjihrig
approved these changes
Apr 17, 2017
jasnell
approved these changes
Apr 17, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 18, 2017
PR-URL: #12451 Ref: #12376 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 2e5188d |
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
PR-URL: #12451 Ref: #12376 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
PR-URL: #12451 Ref: #12376 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #12451 Ref: #12376 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #12376
PR_URL: #12451
Tests updated:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test