src: make accessors immune to context confusion #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var Debug = vm.runInDebugContext('Debug'); | ||
| var breaks = 0; | ||
|
|
||
| function ondebugevent(evt, exc) { |
There was a problem hiding this comment.
Note to self: add comment explaining that exceptions from debug event listeners are swallowed.
mscdex
added
the
c++
| inline Environment* Environment::GetCurrent( | ||
| const v8::PropertyCallbackInfo<v8::Value>& info) { | ||
| const v8::PropertyCallbackInfo<T>& info) { |
There was a problem hiding this comment.
It doesn't look like this is actually needed anywhere. Is it just a new feature?
|
LGTM |
It's possible for an accessor or named interceptor to get called with a different execution context than the one it lives in, see the test case for an example using the debug API. This commit fortifies against that by passing the environment as a data property instead of looking it up through the current context. Fixes: nodejs#1190 (again) PR-URL: nodejs#1238 Reviewed-By: Fedor Indutny <[email protected]>
Remove some unnecessary environment lookups and delete a few superfluous HandleScope variables. PR-URL: nodejs#1238 Reviewed-By: Fedor Indutny <[email protected]>
bnoordhuis
force-pushed
the
fix-issue-1190-take2
branch
from
868f585
to
2e5b87a
Compare
This was referenced Jul 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for an accessor or named interceptor to get called with
a different execution context than the one it lives in, see the test
case for an example using the debug API.
This commit fortifies against that by passing the environment as a
data property instead of looking it up through the current context.
Fixes: #1190 (again)
R=@indutny? /cc @ofrobots
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/362/