-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n-api: fix -Wmismatched-tags compiler warning #12333
Merged
bnoordhuis
merged 1 commit into
nodejs:master
from
bnoordhuis:fix-napi-compiler-warning
Apr 11, 2017
Merged
n-api: fix -Wmismatched-tags compiler warning #12333
bnoordhuis
merged 1 commit into
nodejs:master
from
bnoordhuis:fix-napi-compiler-warning
Apr 11, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Apr 11, 2017
jasnell
approved these changes
Apr 11, 2017
danbev
approved these changes
Apr 11, 2017
addaleax
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and probably shouldn’t need 48 hours to land.
cjihrig
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save you from checking, the CI is green.
`napi_env__` was declared as a struct in one place and a class in another. PR-URL: nodejs#12333 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
fix-napi-compiler-warning
branch
from
April 11, 2017 14:00
57f7df3
to
affe0f2
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
`napi_env__` was declared as a struct in one place and a class in another. PR-URL: nodejs#12333 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
`napi_env__` was declared as a struct in one place and a class in another. Backport-PR-URL: #19447 PR-URL: #12333 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_env__
was declared as a struct in one place and a class inanother.