Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix -Wmismatched-tags compiler warning #12333

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

bnoordhuis
Copy link
Member

napi_env__ was declared as a struct in one place and a class in
another.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 11, 2017
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and probably shouldn’t need 48 hours to land.

@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Apr 11, 2017
@bnoordhuis
Copy link
Member Author

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save you from checking, the CI is green.

`napi_env__` was declared as a struct in one place and a class in
another.

PR-URL: nodejs#12333
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis bnoordhuis force-pushed the fix-napi-compiler-warning branch from 57f7df3 to affe0f2 Compare April 11, 2017 14:00
@bnoordhuis bnoordhuis closed this Apr 11, 2017
@bnoordhuis bnoordhuis deleted the fix-napi-compiler-warning branch April 11, 2017 14:01
@bnoordhuis bnoordhuis merged commit affe0f2 into nodejs:master Apr 11, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
`napi_env__` was declared as a struct in one place and a class in
another.

PR-URL: nodejs#12333
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
`napi_env__` was declared as a struct in one place and a class in
another.

Backport-PR-URL: #19447
PR-URL: #12333
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants