Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add internal/fs tests #12306

Closed
wants to merge 1 commit into from
Closed

test: add internal/fs tests #12306

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

@DavidCai1111 DavidCai1111 commented Apr 10, 2017 •
edited
Loading

  • add tests of internal/fs.js
  • increase coverage
  • move tests of require(internal/fs).stringToFlags in test-fs-open-flags.js to test-internal-fs-string-to-flags.js for a more accurate and findable filename
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 10, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Apr 10, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7305/

cjihrig
cjihrig requested changes Apr 10, 2017
View reviewed changes
test/parallel/test-fs-open-flags.js Outdated
@@ -1,84 +0,0 @@
// Copyright Joyent, Inc. and other Node contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind not renaming this file. It makes the diff a lot nosier than it needs to be.

@DavidCai1111
Copy link
Member Author

@cjihrig OK, Done. PTAL :-)

addaleax pushed a commit to addaleax/node that referenced this pull request Apr 14, 2017
@DavidCai1111 @addaleax
test: add internal/fs tests
f98db78 
PR-URL: nodejs#12306
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member

Landed in f98db78

@addaleax addaleax closed this Apr 14, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Depends on #6749 which depends on a semver-major PR, so marking dont-land. Correct if wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DavidCai1111 @vsemozhetbyt @addaleax @gibfahn @jasnell @cjihrig @mscdex @nodejs-github-bot