Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use $(RM) in Makefile for consistency #12157

Merged
merged 1 commit into from
Apr 4, 2017
Merged

build: use $(RM) in Makefile for consistency #12157

merged 1 commit into from
Apr 4, 2017

Commits on Apr 4, 2017

  1. build: use $(RM) in Makefile for consistency 

    Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of
`rm -f` (the default) should they want to. We're currently using a
mixture of `$(RM)` and `rm -f`.

There are a couple of places which aren't doing -f, have them do it for
consistency.

PR-URL: nodejs#12157
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
    @gibfahn
    gibfahn committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    57b850e View commit details
    Browse the repository at this point in the history