Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: ignore ENOTCONN on shutdown race with child #1214

Merged
merged 1 commit into from
Mar 28, 2015
Merged

src: ignore ENOTCONN on shutdown race with child #1214

merged 1 commit into from
Mar 28, 2015
+8 −0

Commits on Mar 28, 2015

  1. src: ignore ENOTCONN on shutdown race with child 

    On AIX, OS X and the BSDs, calling shutdown() on one end of a pipe
when the other end has closed the connection fails with ENOTCONN.

The sequential/test-child-process-execsync test failed sporadically
because of a race between the parent and the child where one closed
its end of the pipe before the other got around to calling shutdown()
on its end of the pipe.

Libuv is not the right place to handle that because it can't tell if
the ENOTCONN error is genuine but io.js can.

Refs: libuv/libuv#268
PR-URL: nodejs#1214
Reviewed-By: Bert Belder <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 28, 2015
    Configuration menu
    Copy the full SHA
    ea37ac0 View commit details
    Browse the repository at this point in the history