tls: support Uint8Arrays for protocol list buffers #11984
Conversation
addaleax
added
the
semver-minor
addaleax
force-pushed
the
tls-uint8array
branch
from
b29667f
to
5849db1
Compare
|
Why is this one semver-minor when the others are labeled as semver-major? |
|
@mscdex .. the other PRs had error message changes, this one does not. |
| @@ -56,3 +56,17 @@ assert.throws(() => tls.createSecurePair({}), | |||
| assert(buffer.equals(Buffer.from('abcd'))); | |||
| assert(out.NPNProtocols.equals(Buffer.from('efgh'))); | |||
| } | |||
|
|
|||
| { | |||
| const buffer = new Uint8Array([...Buffer.from('abcd')]); | |||
There was a problem hiding this comment.
Why using the spread operator? If I'm not wrong passing a buffer to the Uint8Array constructor (new Uint8Array(Buffer.from('abcd'))) works.
There was a problem hiding this comment.
For this case, indeed it would work. Passing a Buffer to Uint8Array makes the Uint8Array use the identical underlying ArrayBuffer, which at times may not be desirable. But in this case we are creating a new Buffer every time so it should be fine.
There was a problem hiding this comment.
@TimothyGu AFAIK memory is copied to the TypedArray not shared.
There was a problem hiding this comment.
@lpinca, heh I was mistaken. In that case, yeah there's no reason to use spread syntax...
There was a problem hiding this comment.
@lpinca @TimothyGu right, thanks for pointing out. fixed!
addaleax
force-pushed
the
tls-uint8array
branch
from
5849db1
to
dd07fc0
Compare
|
Landed in c3efe72 |
PR-URL: #11984 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
This needs to be manually backported to v7.x |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)