crypto: support Uint8Array prime in createDH #11983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
crypto
addaleax
force-pushed
the
crypto-uint8array
branch
from
b18f95d
to
dbee04c
Compare
addaleax
added
the
semver-major
jasnell
approved these changes
Mar 22, 2017
lpinca
reviewed
Mar 23, 2017
test/parallel/test-crypto-dh.js
Outdated
| const modp2Secret = modp2.computeSecret(exmodp2.getPublicKey()) | ||
| .toString('hex'); | ||
| const exmodp2Secret = exmodp2.computeSecret(modp2.getPublicKey()) | ||
| .toString('hex'); |
There was a problem hiding this comment.
Is there a reason for indenting some of these differently?
There was a problem hiding this comment.
Happens around lines 120, 148, 168 and 172 too.
bnoordhuis
approved these changes
Mar 23, 2017
lib/crypto.js
Outdated
| typeof sizeOrKey !== 'string' && | ||
| !isUint8Array(sizeOrKey)) | ||
| throw new TypeError('First argument should be number, string, ' + | ||
| 'Uint8Array or Buffer'); |
There was a problem hiding this comment.
Maybe add braces while you're here.
test/parallel/test-crypto-dh.js
Outdated
| const modp2Secret = modp2.computeSecret(exmodp2.getPublicKey()) | ||
| .toString('hex'); | ||
| const exmodp2Secret = exmodp2.computeSecret(modp2.getPublicKey()) | ||
| .toString('hex'); |
There was a problem hiding this comment.
Happens around lines 120, 148, 168 and 172 too.
lpinca
approved these changes
Mar 24, 2017
test/parallel/test-crypto-dh.js
Outdated
| { | ||
| // Ensure specific generator (string with encoding) works as expected, | ||
| // with a Uint8Array as the first argument to createDiffieHellman(). | ||
| const exmodp2 = crypto.createDiffieHellman(new Uint8Array([...modp2buf]), |
There was a problem hiding this comment.
Nit: avoid using the spread operator? Feel free to ignore
bnoordhuis
approved these changes
Mar 26, 2017
|
Landed in 0db49fe |
addaleax
added a commit
that referenced
this pull request
Mar 27, 2017
PR-URL: #11983 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)