Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: proper WS URLs when bound to 0.0.0.0 #11850

Merged
merged 1 commit into from
Mar 16, 2017
Merged

inspector: proper WS URLs when bound to 0.0.0.0 #11850

merged 1 commit into from
Mar 16, 2017

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Mar 14, 2017

JSON target list response will now return appropriate IP address
for instances listening on 0.0.0.0.

Refs: #11591
PR-URL: #11755
Reviewed-By: James Snell [email protected]
Reviewed-By: Ben Noordhuis [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: IP is not obtained from the socket

This is a backport of #11755. The only change is that the test now checks if common.skipIfInspectorDisabled exists before calling it.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x labels Mar 14, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Mar 14, 2017

@italoacasas - I am not sure how to create backporting pull requests, please advise.

@eugeneo
Copy link
Contributor Author

eugeneo commented Mar 14, 2017

@italoacasas
Copy link
Contributor

italoacasas commented Mar 14, 2017

@eugeneo you did it great. Thank you

JSON target list response will now return appropriate IP address
for instances listening on 0.0.0.0.

Backport of #11755

PR-URL: #11850
Refs: #11591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: James Snell <[email protected]>
@eugeneo eugeneo merged commit 14e3ad0 into nodejs:v7.x-staging Mar 16, 2017
@eugeneo eugeneo deleted the v7.x-0.0.0.0 branch March 16, 2017 17:00
cjihrig added a commit that referenced this pull request Mar 21, 2017
Notable changes:

* deps: Add node-inspect 1.10.6 (Jan Krems) #11869
* inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850
* tls: fix segfault on destroy after partial read. (Ben Noordhuis) #11898

PR-URL: #11941
cjihrig added a commit that referenced this pull request Mar 21, 2017
Notable changes:

* deps: Add node-inspect 1.10.6 (Jan Krems) #11869
* inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850
* tls: fix segfault on destroy after partial read. (Ben Noordhuis) #11898

PR-URL: #11941
@MylesBorins
Copy link
Contributor

similar to other inspector stuff. Any chance of a mass backport?

imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
    Notable changes:

    * deps: Add node-inspect 1.10.6 (Jan Krems) nodejs/node#11869
    * inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) nodejs/node#11850
    * tls: fix segfault on destroy after partial read. (Ben Noordhuis) nodejs/node#11898

    PR-URL: nodejs/node#11941

Signed-off-by: Ilkka Myller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants