-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRYPTO: Add configure option to use system CA certificates #11774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows distribution packagers to pass a `--system-ca-certificates` argument to `./configure` in order to specify a CA certificate bundle file on the system on which Node will be installed. If this argument is passed, Node will *only* use the system CA certificates and not its internal built-in ones, though they can still be extended through the use of the NODE_EXTRA_CA_CERTS environment variable. Signed-off-by: Stephen Gallagher <[email protected]>
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
labels
Mar 9, 2017
This should be a proper solution for #4175 |
Hmm, I just saw that something landed in Node.js 7.5.0 that is similar... |
2 tasks
This was referenced Mar 7, 2020
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows distribution packagers to pass a
--system-ca-certificates
argument to./configure
in order tospecify a CA certificate bundle file on the system on which Node
will be installed. If this argument is passed, Node will only
use the system CA certificates and not its internal built-in ones,
though they can still be extended through the use of the
NODE_EXTRA_CA_CERTS environment variable.
Signed-off-by: Stephen Gallagher [email protected]
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
crypto