Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixups #1148

Merged
merged 2 commits into from
Mar 16, 2015
Merged

Minor fixups #1148

merged 2 commits into from
Mar 16, 2015

Commits on Mar 16, 2015

  1. src: don't create js string twice on error 

    Rewrite ErrnoException() so that it doesn't turn the file path into a
string twice.

PR-URL: nodejs#1148
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    4f39499 View commit details
    Browse the repository at this point in the history

  2. src: use Number::New() for heapTotal/heapUsed 

    With --max_old_space_size=12345 it's possible to create a JS heap that
is larger than what fits in an unsigned int so use Number::New() rather
than Integer::NewFromUnsigned().

Performance-wise, it doesn't matter much.  If V8 can fit the double in
a SMI, it will.

PR-URL: nodejs#1148
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 16, 2015
    Configuration menu
    Copy the full SHA
    2551c1d View commit details
    Browse the repository at this point in the history