Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix building with ninja on linux #11348

Closed
wants to merge 1 commit into from

Conversation

kenany
Copy link
Contributor

@kenany kenany commented Feb 13, 2017

On Linux, ninja appears to place libv8_base.a inside OBJ_DIR, as opposed to ninja on OS X which places it outside of that directory. Furthermore, the expected OBJ_DIR value (obj.target/) is actually just obj/ for ninja. This patch solves both of these issues by setting OBJ_DIR and V8_BASE to the
correct values for ninja on Linux specifically.

Fixes: #9861

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem

build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 13, 2017
@kenany
Copy link
Contributor Author

kenany commented Feb 13, 2017

/cc @Fishrock123, @gibfahn (to test on OS X?). @sam-github (who also had this issue)

On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed
to `ninja` on OS X which places it outside of that directory. Furthermore, the
expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`.
This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the
correct values for `ninja` on Linux specifically.

Fixes: nodejs#9861
@sam-github
Copy link
Contributor

Built on Linux for me. Doing some rebuilding to see if ninja is faster than make, LGTM

@Fishrock123
Copy link
Contributor

Seems to work fine for me on macOS 10.10.5

Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on macOS 10.12 (Sierra).

@jasnell
Copy link
Member

jasnell commented Feb 16, 2017

CI only to make sure there's no impact on regular build: https://ci.nodejs.org/job/node-test-pull-request/6454/

jasnell pushed a commit that referenced this pull request Feb 17, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed
to `ninja` on OS X which places it outside of that directory. Furthermore, the
expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`.
This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the
correct values for `ninja` on Linux specifically.

PR-URL: #11348
Fixes: #9861
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 17, 2017

Landed in 70afe9d

@jasnell jasnell closed this Feb 17, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed
to `ninja` on OS X which places it outside of that directory. Furthermore, the
expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`.
This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the
correct values for `ninja` on Linux specifically.

PR-URL: nodejs#11348
Fixes: nodejs#9861
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed
to `ninja` on OS X which places it outside of that directory. Furthermore, the
expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`.
This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the
correct values for `ninja` on Linux specifically.

PR-URL: #11348
Fixes: #9861
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

needs a backport PR to land on v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants