test: improve crypto coverage #11279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If possible, it would be great if the regular expressions could cover the entire error message. For example, instead of |
|
@nodejs/testing |
toiroakr
force-pushed
the
test-improve-crypto-coverage
branch
from
c2701df
to
ccc74df
Compare
|
@Trott Thanks! fixed. |
hiroppy
reviewed
Feb 10, 2017
test/parallel/test-crypto-dh.js
Outdated
| // invalid test: curve argument is undefined | ||
| assert.throws(() => { | ||
| crypto.createECDH(); | ||
| }, /"curve" argument should be a string/); |
There was a problem hiding this comment.
You can change this line to /^TypeError: "curve" argument should be a string$/.
- check exception when ECDH curve is undefined - check exception when getPublicKey format is invalid
toiroakr
force-pushed
the
test-improve-crypto-coverage
branch
from
ccc74df
to
b95d606
Compare
|
@abouthiroppy Thanks! and sorry for letting you point out the same thing. I fixed it. |
cjihrig
approved these changes
Feb 10, 2017
hiroppy
approved these changes
Feb 10, 2017
santigimeno
approved these changes
Feb 10, 2017
jasnell
approved these changes
Feb 10, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 17, 2017
* check exception when ECDH curve is undefined * check exception when getPublicKey format is invalid PR-URL: #11279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed on 513d9bb |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
* check exception when ECDH curve is undefined * check exception when getPublicKey format is invalid PR-URL: nodejs#11279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
* check exception when ECDH curve is undefined * check exception when getPublicKey format is invalid PR-URL: #11279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* check exception when ECDH curve is undefined * check exception when getPublicKey format is invalid PR-URL: #11279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
will need a backport PR to land on v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* check exception when ECDH curve is undefined * check exception when getPublicKey format is invalid PR-URL: #11279 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage on crypto dh functions.
Just add 2 exceptions check.
Please review.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A