Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-http-response-statuscode #11274

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 9, 2017

  • move repeated code to function
  • use strings for expected error (exposes result for [] as empty string)
  • remove unneeded common.mustCall() usage with function arguments that
    are not callbacks
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 9, 2017
@Trott Trott added the http Issues or PRs related to the http subsystem. label Feb 9, 2017
@Trott
Copy link
Member Author

Trott commented Feb 10, 2017

@Trott
Copy link
Member Author

Trott commented Feb 13, 2017

Landed in dd1cf8b

@Trott Trott closed this Feb 13, 2017
Trott added a commit that referenced this pull request Feb 13, 2017
* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks

PR-URL: #11274
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@italoacasas
Copy link
Contributor

@Trott this is not landing in v7 clearly, any plan to backport?

@Trott
Copy link
Member Author

Trott commented Feb 14, 2017

@italoacasas It depends on #11221 which is semver-major. I think it's OK to not land this one on 7.x.x.

krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
* move repeated code to function
* use strings for expected error (exposes result for [] as empty string)
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks

PR-URL: nodejs#11274
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@jasnell jasnell mentioned this pull request Apr 4, 2017
@Trott Trott deleted the statuscode branch January 13, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants