Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons doc fixes #1125

Merged
merged 5 commits into from
Mar 21, 2015
Merged

Addons doc fixes #1125

merged 5 commits into from
Mar 21, 2015

Commits on Mar 21, 2015

  1. doc: remove uses of v8::Isolate::GetCurrent() 

    v8::Isolate::GetCurrent() is slated for deprecation.  Replace its uses
in the addons documentation with v8::Object::GetIsolate(), etc.

PR-URL: nodejs#1125
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2015
    Configuration menu
    Copy the full SHA
    409d413 View commit details
    Browse the repository at this point in the history

  2. doc: remove unnecessary v8::HandleScopes 

    Remove unnecessary v8::HandleScope uses from the addons documentation.

C++ API callbacks run in an implicit v8::HandleScope, there is no need
to declare one in the callback function.

PR-URL: nodejs#1125
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2015
    Configuration menu
    Copy the full SHA
    2f1b783 View commit details
    Browse the repository at this point in the history

  3. doc: replace v8::Handle<T> with v8::Local<T> 

    v8::Handle is on its way out, to be replaced with v8::Local.  Update the
addons documentation accordingly.

PR-URL: nodejs#1125
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2015
    Configuration menu
    Copy the full SHA
    c4e1b82 View commit details
    Browse the repository at this point in the history

  4. doc: don't use using namespace v8 

    Wholesale importing an entire namespace with `using namespace` is a bad
practice.  Remove it from the addons documentation and replace it with
proper `using` directives.  Wrap code in a namespace while we are here.

PR-URL: nodejs#1125
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2015
    Configuration menu
    Copy the full SHA
    55abf34 View commit details
    Browse the repository at this point in the history

  5. doc: call js function in null context 

    It's good practice now to call JS functions that don't execute in a
specific scope with v8::Null() as the receiver.  Update the addons
documentation.

PR-URL: nodejs#1125
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 21, 2015
    1 Configuration menu
    Copy the full SHA
    99c79f8 View commit details
    Browse the repository at this point in the history