stream: minor fix for ReadableState #11139
Conversation
It seems that the comments for sync flag of ReadableState is copied from WritableState without modification.
nodejs-github-bot
added
the
stream
cynron
changed the title
|
@nodejs/streams |
|
Given that this removes a property, this is potentially semver-major. It shouldn't be, but we need to be certain. |
addaleax
added
the
semver-major
|
I think we are going to release this as semver-minor in
|
|
Landed as 1004b9b and 202b07f |
flag `ranOut` became unused since 0f8de5e, but 0f8de5e did not remove it. PR-URL: #11139 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
It seems that the comment for sync flag of ReadableState is copied from WritableState without modification. PR-URL: #11139 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
@mcollina Just ICYMI, our current policy is that at least 2 CTC members need to sign off on semver-major changes before landing them. I don’t think that’s a problem here because it’s not something that’s really covered by our API (as you pointed out)… I just added the label because, at least from Node’s perspective, I don’t think there’s a reason to not consider this semver-major. |
|
Oh, I thought this was sitting there for a while, and just reduced the pull requests count by one. |
remove unused flag
ranOutfrom ReadableState,ranOuthad been unused since 0f8de5efix the comments for flag
syncof ReadableState.Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)