Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve readline coverage to check end and clear keys #11131

Closed

Conversation

chiiia12
Copy link

@chiiia12 chiiia12 commented Feb 3, 2017

I improved test coverage for readline. I found some key tests are missing. This PR will improve coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2017
@yosuke-furukawa
Copy link
Member

Hello, @nodejs/collaborators .
I am teaching about how to contribute node.js in my office (like code-and-learn) .
She would like to contribute improvement some tests. please review.

@hiroppy hiroppy added the readline Issues and PRs related to the built-in readline module. label Feb 3, 2017
@hiroppy
Copy link
Member

hiroppy commented Feb 3, 2017

Hello, chiiia12 and Yosuke!
Thank you for your contribution 😘
This is LGTM but I submitted the same tests before. #10772

@chiiia12 chiiia12 closed this Feb 3, 2017
@chiiia12
Copy link
Author

chiiia12 commented Feb 3, 2017

Hello, abouthiroppy!
Thanks for your review!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants