Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.x: backport a few WHATWG URL changes #11069

Merged
merged 3 commits into from
Jan 31, 2017
Merged

v7.x: backport a few WHATWG URL changes #11069

merged 3 commits into from
Jan 31, 2017

Commits on Jan 31, 2017

  1. url: stop exporting originFor() 

    PR-URL: nodejs#10955
Fixes: nodejs#10800
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
    @TimothyGu
    TimothyGu committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    57e5315 View commit details
    Browse the repository at this point in the history

  2. url: do not public expose inspect methods on URL 

    PR-URL: nodejs#10906
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @TimothyGu
    TimothyGu committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    499e75a View commit details
    Browse the repository at this point in the history

  3. url: define @@toStringTag as a data property 

    Even though this is not fully Web IDL spec-compliant, it is arguably the
best we can do. Following the spec would mean non-trivial performance
deterioration (10% when parsing a medium-length URL), while the current
getter behavior is not adopted by any implementer, and it causes some
spec ambiguity when the getter is called with !(this instanceof URL).

This commit adopts Chrome's behavior, and is consistent with
ECMAScript-defined classes while providing reasonable behaviors for
corner cases as well. Until the Web IDL spec is changed one way or
another, this is the way to go.

PR-URL: nodejs#10906
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @TimothyGu
    TimothyGu committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    b94eec1 View commit details
    Browse the repository at this point in the history