deps: upgrade npm to 4.1.2 #11020
deps: upgrade npm to 4.1.2 #11020
Conversation
nodejs-github-bot
added
the
npm
|
@zkat ... I appreciate this. It would be helpful if you would consider adding links to the relevant commits/PRs for each of the "description of change" bullet points. In particular I'd like to review the file URL changes a bit more in detail to understand more about what is happening there. I will try to give this a review by early next week |
|
@zkat oh no. Our old friend is back... in a new form: |
|
Ok, 4.1.1 merged. I guess the best way forward here is to rename the file in a separate commit first and then do the rest including whatever changed within the file? |
|
@Fishrock123 I'm so angry. I'm so so angry. I hate git so much sometimes. I hate OSX's (and Windows') wobbly bullshit with case-insensitivity. I hate joy and happyness.... anyway yeah that sounds like a good plan. I'll try it again in a wee bit. @jasnell Yeah, one sec and I'll look those up for you. Watch for an edit in a few minutes. |
|
@Fishrock123 I rebased and did |
|
@jasnell incidentally, the |
|
@zkat definitely still running into issues. :/ |
|
@Fishrock123 one more try? Just pushed a new one. |
|
@zkat Nice, great work. Seems to land fine. Here's to hoping it doesn't also have lingering side effects. Curious though, what did you do? |
git reset head~1
cd deps/npm/(...)/form-data
# need to do a two-step move because OSX will noop a plain case-only move
mv README.md rm.md
mv rm.md Readme.md
git add -A && git commit -m 'deps: upgrade npm to 4.1.2'And then I just check the commit summary to make sure there's not a file addition for |
|
That is cool! |
|
@targos not much to get excited about, imo. that's probably just from some part of the dependency tree being flattened because of recursive dependencies getting updated and thus allowing more deduping. |
|
Not much I agree, but the tarball should still be noticeably smaller |
|
@targos absolutely! you're right. And that's actually p. nice. |
|
thank you @zkat! |
PR-URL: nodejs#11020 Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Thanks, landed in afb7c1b! |
|
Was there a CI run on this PR? Anyone still has the link? |
|
when this lands it will need to come with 35e749b |
PR-URL: #11020 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Notable changes: * crypto: * ability to select cert store at runtime (Adam Majer) #8334 * Use system CAs instead of using bundled ones (Adam Majer) #8334 * deps: * upgrade npm to 4.1.2 (Kat Marchán) #11020 * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021 * doc: add basic documentation for WHATWG URL API (James M Snell) #10620 * process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * url: allow use of URL with http.request and https.request (James M Snell) #10638 PR-URL: #11062
Notable changes: * crypto: * ability to select cert store at runtime (Adam Majer) #8334 * Use system CAs instead of using bundled ones (Adam Majer) #8334 * deps: * upgrade npm to 4.1.2 (Kat Marchán) #11020 * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021 * doc: add basic documentation for WHATWG URL API (James M Snell) #10620 * process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * url: allow use of URL with http.request and https.request (James M Snell) #10638 PR-URL: #11062
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
depsDescription of Change
npm doctornpm/npm#14582 Adds the new npm doctor command.[email protected]officially dropped.package.json,npm-shrinkwrap.json, or.npmrc.Additional notes
Heads-up that
npm@nextis currently a semver-minor bump to[email protected]which includes a significant improvement for search. We'll downstream it in two weeks but it might be worth pointing out that bump cause it's something folks might want in LTS (specially since it has to do with a side utility/service rather than installation and the like). Cheers!Changelogs
v4.1.0v4.1.1v4.1.2r: @Fishrock123
r: @jasnell
r: @addaleax