Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add TupleOrigin's test for url #10953

Closed
wants to merge 1 commit into from
Closed

test: add TupleOrigin's test for url #10953

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 22, 2017 •
edited
Loading

Increase coverage for TupleOrigin of url.

TupleOrigin: https://github.com/nodejs/node/blob/master/lib/internal/url.js#L42
Coverage: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/internal/url.js.html

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@hiroppy
test: add TupleOrigin's test for url
4194820 
Increase coverage for TupleOrigin.
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 22, 2017
@mscdex mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 22, 2017
@TimothyGu
Copy link
Member

I'd prefer holding off on this PR, since there's an outstanding issue in #10800 that may impact the entire originFor function.

@joyeecheung
Copy link
Member

Specifically this is in conflict with #10955

@hiroppy
Copy link
Member Author

hiroppy commented Jan 23, 2017

OK, so I will close this PR.

@hiroppy hiroppy closed this Jan 23, 2017
@hiroppy hiroppy deleted the feature/add-tuple-origin-test branch January 23, 2017 13:52
@hiroppy hiroppy restored the feature/add-tuple-origin-test branch January 23, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hiroppy @TimothyGu @joyeecheung @cjihrig @mscdex @nodejs-github-bot