Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added msg verification on assert.throws #10890

Closed
wants to merge 1 commit into from
Closed

test: added msg verification on assert.throws #10890

wants to merge 1 commit into from

Conversation

tmeisenh
Copy link
Contributor

@tmeisenh tmeisenh commented Jan 19, 2017 •
edited by gibfahn
Loading

Note: The string representation of a regexp reorders the modifiers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 19, 2017
Trott
Trott reviewed Jan 19, 2017
View reviewed changes
test/parallel/test-assert.js
assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));
assert.throws(makeBlock(a.deepEqual, /ab/, /a/), /\/ab\/ deepEqual \/a\//);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if the regexp matched the full error message start to finish, so more like this:

/^AssertionError: \/ab\/ deepEqual \/a\/$/

@mscdex mscdex added the assert Issues and PRs related to the assert subsystem. label Jan 19, 2017
@tmeisenh
Copy link
Contributor Author

Added changes from last review from @Trott.

cjihrig
cjihrig requested changes Jan 20, 2017
View reviewed changes
test/parallel/test-assert.js
assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));
assert.throws(makeBlock(a.deepEqual, /ab/, /a/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you add $ to the end of the regular expressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done!

@tmeisenh
test: added full msg verification on assert.throws
29720bb 
Note: The string representation of a regexp reorders the modifiers.
@lpinca
Copy link
Member

lpinca commented Jan 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5973/

@lpinca lpinca mentioned this pull request Jan 21, 2017
Closed
4 tasks
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 22, 2017
@tmeisenh @Trott
test: add message verification on assert.throws
3e7a414 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: nodejs#10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Jan 22, 2017

Landed in 3e7a414.
Thanks for the contribution! 🎉

@Trott Trott closed this Jan 22, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@tmeisenh @italoacasas
test: add message verification on assert.throws
4e2414c 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: nodejs#10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@tmeisenh @italoacasas
test: add message verification on assert.throws
a173cba 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: nodejs#10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@tmeisenh @italoacasas
test: add message verification on assert.throws
c4f1694 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: nodejs#10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@tmeisenh @italoacasas
test: add message verification on assert.throws
1cabdc8 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: nodejs#10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@tmeisenh @MylesBorins
test: add message verification on assert.throws
8a21d2a 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: #10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@tmeisenh @MylesBorins
test: add message verification on assert.throws
9f261a6 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: #10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@tmeisenh @MylesBorins
test: add message verification on assert.throws
ca53866 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: #10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@tmeisenh @MylesBorins
test: add message verification on assert.throws
7bceb4f 
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.

PR-URL: #10890
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tmeisenh @lpinca @Trott @addaleax @targos @cjihrig @mscdex @MylesBorins @nodejs-github-bot