v7.x backport - doc: correct vcbuild options for windows testing #10686
Conversation
gibfahn
added
doc
nodejs-github-bot
added
doc
|
@jboarman I reopened your PR, the commit is still attributed to you, let me know if that's okay. |
|
@MylesBorins this needs to land on v7, v6, and v4 (but not master), should I retarget this PR to EDIT: Did that, let me know if it's wrong... |
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members.
gibfahn
force-pushed
the
vcbuild-nosign
branch
from
3a7e9cd
to
3cf4399
Compare
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
|
Landed in ed9b6c1 |
|
@jasnell it looks like ed9b6c1 landed in @nodejs/lts what do we do now? Do we revert this in master? |
gibfahn
changed the title
|
aw dangit... I must have forgotten to switch branches. ok, thanks for spotting this. glad it wasn't something more substantial |
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
gibfahn
changed the title
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
italoacasas
force-pushed
the
v7.x-staging
branch
from
376b9a4
to
506a50b
Compare
evanlucas
force-pushed
the
v7.x-staging
branch
from
b94eec1
to
13a024d
Compare
|
This has landed correctly in |
|
@joaocgreis please hold off on backporting to staging. We generally don't land anything until it has lived in master for at least two weeks. We are also mid release cycle, so anything on staging will need to be rebased. If you want to guarantee that specific commits land together I suggest opening a backport PR |
|
@MylesBorins this is a docs-only bugfix PR, which also only affects people building from source on Windows (it only changes |
|
Ah, didn't realize it was docs only... backport away, I can wrap it into the next release |
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
|
Landed in I believe we now have this correct in all branches. |
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.
Reopened version of #10112, I added
.\and changedtest nosign->nosign testas per comments in that PR (and also change commit message to be <50 chars).Checklist
Affected core subsystem(s)
doc, win