Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor the code of test-keep-alive.js #10684

Closed
wants to merge 2 commits into from
Closed

test: refactor the code of test-keep-alive.js #10684

wants to merge 2 commits into from

Conversation

sivaprs
Copy link
Contributor

@sivaprs sivaprs commented Jan 8, 2017

  • use const and let instead of var
  • use assert.strictEqual instead of assert.equal
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

description

  • use const and let instead of var
  • use assert.strictEqual instead of assert.equal
  • use arrow functions

@sivaprs
test: refactor the code of test-keep-alive.js
6785f7a 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 8, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Jan 8, 2017
@sivaprs
Copy link
Contributor Author

sivaprs commented Jan 8, 2017

cc @thefourtheye

cjihrig
cjihrig approved these changes Jan 8, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that the pummel tests aren't run in the CI.

thefourtheye
thefourtheye reviewed Jan 9, 2017
View reviewed changes
test/pummel/test-keep-alive.js
server.listen(common.PORT, function() {
runAb({ keepalive: true }, function(reqSec) {
server.listen(common.PORT, () => {
runAb({ keepalive: true }, (reqSec) => {
keepAliveReqSec = reqSec;
console.log('keep-alive:', keepAliveReqSec, 'req/sec');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove all the console.logs and the commented console.log in this file.

@sivaprs
test: refactor test-keep-alive.js
d0a9f55 
removed console.log statements
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5791/

jasnell pushed a commit that referenced this pull request Jan 10, 2017
@sivaprs @jasnell
test: refactor the code of test-keep-alive.js
aacd323 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: #10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

Landed in aacd323

@jasnell jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sivaprs @italoacasas
test: refactor the code of test-keep-alive.js
4ef988b 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: nodejs#10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sivaprs @italoacasas
test: refactor the code of test-keep-alive.js
8b50ba4 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: nodejs#10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@sivaprs @italoacasas
test: refactor the code of test-keep-alive.js
19733a1 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: nodejs#10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sivaprs @italoacasas
test: refactor the code of test-keep-alive.js
cb111c9 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: nodejs#10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor the code of test-keep-alive.js
0262497 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: #10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor the code of test-keep-alive.js
b2d9cc6 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: #10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor the code of test-keep-alive.js
119e512 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: #10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor the code of test-keep-alive.js
f86c64a 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed console.log statements

PR-URL: #10684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sivaprs @jasnell @thefourtheye @cjihrig @mscdex @MylesBorins @nodejs-github-bot