test: add test-cluster-worker-deprecated #10675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests.
Trott
added
cluster
nodejs-github-bot
added
the
cluster
jasnell
approved these changes
Jan 7, 2017
sam-github
suggested changes
Jan 9, 2017
| @@ -31,14 +31,12 @@ function Worker(options) { | |||
| this.exitedAfterDisconnect = undefined; | |||
|
|
|||
| Object.defineProperty(this, 'suicide', { | |||
| get: internalUtil.deprecate(() => { | |||
There was a problem hiding this comment.
I would describe this as cluster: better suicide deprecation message (or something of the like), since its a change to improve the deprecation message, along with a unit test for that change.
There was a problem hiding this comment.
@sam-github The deprecation message is not being changed here.
The new test exercises the getter and setter. They were not being exercised. The code change to cluster.js refactor the getter/setter for clarity (good-bye, string concatenation), but do not change the behavior.
There was a problem hiding this comment.
OK, I missed that, the diff is hard to read. Shouldn't a change to lib/cluster.js have cluster: in its commit message? Even if its just a stylistic change?
sam-github
approved these changes
Jan 10, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 10, 2017
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
|
Landed in 3f61521 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to cover setter for deprecated cluster Worker property.
Previously, the setter was not being exercised in tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster