-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: modify pull request template for prepending #10484
Conversation
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In case anyone else was wondering, for multi-commit PRs Github doesn't seem include any commit messages at all.
is it safe to assume there is no way to specify where this data will end up? was much nicer at the end. |
I think this one is trivial enough not to have to wait the full 48 hours to land |
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Landed 8dcebe8 |
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Myles Borins <[email protected]>
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Myles Borins <[email protected]>
The GitHub interface for new pull requests has started prepending
commit messages for single-commit pull requests. It had previously
been appending them. Modify the GitHub template to accommodate the new
behavior.
Checklist
Affected core subsystem(s)
meta