Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: allow benchmarks to specify flags #10448

Closed
wants to merge 2 commits into from
Closed

benchmark: allow benchmarks to specify flags #10448

wants to merge 2 commits into from

Commits on Dec 30, 2016

  1. benchmark: allow benchmarks to specify flags 

    * Give createBenchmark and the Benchmark constructor
  a third argument for specifying the command line flags
  that this benchmark should be run with.
  The benchmarks are no longer run with --expose-internals
  by default, they will need to explicitly pass the flags.
* Rename options to configs in createBenchmark and the Benchmark
  constructor to match the documentation since they are not optional.
* Comment the properties of a Benchmark object
    @joyeecheung
    joyeecheung committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    54f2f07 View commit details
    Browse the repository at this point in the history

  2. doc: describe how the benchmarks are run 

    * Add detailed description of the arguments of `createBenchmark`
* Describe the two passes of running the benchmarks
* Suggest what kind of code should go where in the benchmark example
    @joyeecheung
    joyeecheung committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    f3f864c View commit details
    Browse the repository at this point in the history