Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix racey-ness in tls-inception #1040

Closed
wants to merge 1 commit into from

Commits on Mar 3, 2015

  1. test: fix racey-ness in tls-inception

    Fix test failure on FreeBSD and SmartOS, which happens due to a bad
    timing:
    
        events.js:141
              throw er; // Unhandled 'error' event
                    ^
        Error: read ECONNRESET
            at exports._errnoException (util.js:734:11)
            at TLSWrap.onread (net.js:538:26)
    
    The outer `net.conncet()` socket stays alive after the inner socket is
    gone. This happens because `.pipe()`'s implementation does not `destroy`
    the source side when the destination has emitted `close`.
    
    Fix: nodejs#1012
    indutny committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    0eabef3 View commit details
    Browse the repository at this point in the history