stream, test: add test for _readableState.needReadable #10241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lts-watch-v4.x
test
joyeecheung
changed the title
joyeecheung
changed the title
joyeecheung
force-pushed
the
test-need-readable
branch
from
a60240d
to
95d505b
Compare
mscdex
reviewed
Dec 12, 2016
| // When the readable event fires, needReadable is reset. | ||
| assert.strictEqual(readable._readableState.needReadable, false); | ||
| readable.read(); | ||
| }), 1); |
There was a problem hiding this comment.
I think the , 1 here is a typo and should be removed.
There was a problem hiding this comment.
Thank you for pointing this out. That's meant for common.mustCall but I accidentally put it inside the wrong parentheses. The default is 1 anyway so I agree with you, this can be removed.
|
I have removed the misplaced argument to |
|
ARM failure unrelated, @mscdex you merge or should I merge? |
italoacasas
approved these changes
Dec 13, 2016
3 tasks
|
I discovered that the slowProducer example is not covered accurately(pushing is done synchronously). Can I improve this a little bit more? |
|
@joyeecheung Sure go ahead. |
joyeecheung
force-pushed
the
test-need-readable
branch
from
0af8783
to
e3c5f63
Compare
joyeecheung
force-pushed
the
test-need-readable
branch
from
e3c5f63
to
9769f34
Compare
|
Updates pushed, please take a look @mcollina . |
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
PR-URL: #10241 Ref: #8683 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
stream, test
Description of change
Part of #10230 & #8644, increase coverage of the internal state machine of streams.