-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix setTimeout, add const, remove unused var #10207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is ✅ .
Not sure why the bot labeled it don't-land-on-v7--maybe it sees a modified test and thinks it might be a behavior change?
The CI check failed on |
The Raspberry Pi that failed had its failure during build and not test. That particular job doesn't run this test anyway. And that particular Raspberry Pi was having build failures throughout the day. (One of the admins rebooted it after I brought it to their attention, but that was after this CI run.) In short, the single CI failure is unrelated and can be ignored. |
apply setTimeout duration, add const, remove unused var PR-URL: nodejs#10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Landed in ca58e53. |
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test/parallel/test-domain.js
Description of change
Added 1ms delay for setTimeout and setInterval, instead of default 0. Changed var->const in 4 places. Removed unused function parameter.